fix: Show DateTime tooltip even for older transactions

usame-algan commented 1 week ago

What it solves

Resolves #3115

Transactions are displayed either with a timestamp in hours, a datetime or time in words

timestamp in hours -> In the tx history and only if no filter is applied

datetime -> In the tx queue if older than 60 days -> In the tx history if a filter is applied

time in words -> In the tx queue if within 60 days

The tooltip contains the datetime so it should only be visible if either timestamp in hours is shown or time in words

How this PR fixes it

Adjusts the condition to include the case where a transaction is older than 60 days but where the timestamp in hours is still shown

How to test it

Open the tx history
Scroll enough to get to transactions older than 60 days
Hover the timestamp
Observe a tooltip with datetime showing

Screenshots

Checklist

[ ] I've tested the branch on mobile 📱
[ ] I've documented how it affects the analytics (if at all) 📊
[ ] I've written a unit/e2e test for it (if applicable) 🧑‍💻

github-actions[bot] commented 1 week ago

Branch preview

✅ Deploy successful!

Website: https://datetime_tooltip--walletweb.review.5afe.dev/home?safe=eth:0xA77DE01e157f9f57C7c4A326eeE9C4874D0598b6

Storybook: https://datetime_tooltip--walletweb.review.5afe.dev/storybook/

github-actions[bot] commented 1 week ago

ESLint Summary View Full Report

Annotations are provided inline on the Files Changed tab. You can also see all annotations that were generated on the annotations page.

Type	Occurrences	Fixable
Errors	0	0
Warnings	0	0
Ignored	0	N/A

Result: :white_check_mark: success
- Annotations: 0 total

^{Report generated by eslint-plus-action}

github-actions[bot] commented 1 week ago

📦 Next.js Bundle Analysis for safe-wallet-web

This analysis was generated by the Next.js Bundle Analysis action. 🤖

Seven Pages Changed Size

The following pages changed size from the code in this PR compared to its base branch:

Page	Size (compressed)	First Load
`/apps/open`	`53.29 KB` (🟡 +3 B)	1.03 MB
`/transactions`	`73.42 KB` (🟡 +3 B)	1.05 MB
`/transactions/history`	`73.39 KB` (🟡 +3 B)	1.05 MB
`/transactions/messages`	`39.02 KB` (🟡 +3 B)	1.02 MB
`/transactions/msg`	`29.42 KB` (🟡 +3 B)	1.01 MB
`/transactions/queue`	`31.01 KB` (🟡 +3 B)	1.01 MB
`/transactions/tx`	`20.78 KB` (🟡 +3 B)	1021.55 KB

Details

Only the gzipped size is provided here based on an expert tip.

First Load is the size of the global bundle plus the bundle for the individual page. If a user were to show up to your website and land on a given page, the first load size represents the amount of javascript that user would need to download. If next/link is used, subsequent page loads would only need to download that page's bundle (the number in the "Size" column), since the global bundle has already been downloaded.

Any third party scripts you have added directly to your app using the <script> tag are not accounted for in this analysis

Next to the size is how much the size has increased or decreased compared with the base branch of this PR. If this percentage has increased by 20% or more, there will be a red status indicator applied, indicating that special attention should be given to this.

github-actions[bot] commented 1 week ago

Coverage report

St.^{:grey_question:}	Category	Percentage	Covered / Total
🟡	Statements	78.86% (+0% 🔼)	11599/14708
🔴	Branches	58.03% (+0.02% 🔼)	2819/4858
🟡	Functions	65.74%	1850/2814
🟢	Lines	80.27% (+0% 🔼)	10461/13032

Test suite run success

1426 tests passing in 197 suites.

Report generated by 🧪jest coverage report action from ad1b6ebaa96d24a6b21f74de7855869b295e5b7d

francovenica commented 6 days ago

LGTM. Tooltips show when the should now

safe-global / safe-wallet-web