Fix: correct filtering of history for txs marked trusted and imitation

safe-global / safe-wallet-web

Safe{Wallet} – smart contract wallet for Ethereum (ex-Gnosis Safe multisig)

https://app.safe.global

GNU General Public License v3.0

314 stars 372 forks source link

Fix: correct filtering of history for txs marked trusted and imitation #3907

Open jmealy opened 1 week ago

jmealy commented 1 week ago

What it solves

If there is a transaction marked with trusted: true and imitation: true, then it does not get filtered with the hide malicious toggle in the transaction history page.

How this PR fixes it

Specify the imitation query param for the /history endpoint, based on the value of the hide malicious toggle button on the transaction history page.
Also rename the hide malicious toggle in user settings to reflect the new name in the UI, and differentiate from the trusted flag on transactions.

github-actions[bot] commented 1 week ago

Branch preview

❌ Deploy failed!

github-actions[bot] commented 1 week ago

ESLint Summary View Full Report

Annotations are provided inline on the Files Changed tab. You can also see all annotations that were generated on the annotations page.

Type	Occurrences	Fixable
Errors	0	0
Warnings	0	0
Ignored	0	N/A

Result: :white_check_mark: success
- Annotations: 0 total

^{Report generated by eslint-plus-action}

github-actions[bot] commented 1 week ago

Coverage report

St.^{:grey_question:}	Category	Percentage	Covered / Total
🟡	Statements	78.86%	11598/14707
🔴	Branches	58.01%	2817/4856
🟡	Functions	65.74%	1850/2814
🟢	Lines	80.27%	10460/13031

Test suite run success

1426 tests passing in 197 suites.

Report generated by 🧪jest coverage report action from 8d013a452f3244fb81e828d0f4db735a7636bfa8