safe-global / safe-wallet-web

Safe{Wallet} – smart contract wallet for Ethereum (ex-Gnosis Safe multisig)
https://app.safe.global
GNU General Public License v3.0
314 stars 372 forks source link

fix: mark imitation txs opaque #3908

Closed schmanu closed 1 week ago

schmanu commented 1 week ago

What it solves

Our previous address poisoning and spam protection made transactions slightly opaque in the history to help users quickly distinguish them. The new address poisoning flagging does not make them opaque at the moment.

How this PR fixes it

How to test it

Find a Safe with transactions that only get flagged through our new detection: Address poisoning attempts which actually transfer legit tokens.

Screenshots

Before:

Screenshot 2024-07-04 at 21 25 15

After:

Screenshot 2024-07-04 at 21 25 03

Checklist

github-actions[bot] commented 1 week ago

Branch preview

✅ Deploy successful!

Website: https://fix_imitation_txs_opaque--walletweb.review.5afe.dev/home?safe=eth:0xA77DE01e157f9f57C7c4A326eeE9C4874D0598b6

Storybook: https://fix_imitation_txs_opaque--walletweb.review.5afe.dev/storybook/

notion-workspace[bot] commented 1 week ago

Posoning attempt tx not blurred out

github-actions[bot] commented 1 week ago

ESLint Summary View Full Report

Annotations are provided inline on the Files Changed tab. You can also see all annotations that were generated on the annotations page.

Type Occurrences Fixable
Errors 0 0
Warnings 0 0
Ignored 0 N/A

Report generated by eslint-plus-action

github-actions[bot] commented 1 week ago

📦 Next.js Bundle Analysis for safe-wallet-web

This analysis was generated by the Next.js Bundle Analysis action. 🤖

Seven Pages Changed Size

The following pages changed size from the code in this PR compared to its base branch:

Page Size (compressed) First Load
/apps/open 53.29 KB (🟡 +4 B) 1.03 MB
/transactions 73.43 KB (🟡 +4 B) 1.05 MB
/transactions/history 73.39 KB (🟡 +4 B) 1.05 MB
/transactions/messages 39.02 KB (🟡 +4 B) 1.02 MB
/transactions/msg 29.42 KB (🟡 +4 B) 1.01 MB
/transactions/queue 31.01 KB (🟡 +4 B) 1.01 MB
/transactions/tx 20.78 KB (🟡 +4 B) 1021.56 KB
Details

Only the gzipped size is provided here based on an expert tip.

First Load is the size of the global bundle plus the bundle for the individual page. If a user were to show up to your website and land on a given page, the first load size represents the amount of javascript that user would need to download. If next/link is used, subsequent page loads would only need to download that page's bundle (the number in the "Size" column), since the global bundle has already been downloaded.

Any third party scripts you have added directly to your app using the <script> tag are not accounted for in this analysis

Next to the size is how much the size has increased or decreased compared with the base branch of this PR. If this percentage has increased by 20% or more, there will be a red status indicator applied, indicating that special attention should be given to this.

github-actions[bot] commented 1 week ago

Coverage report

St.:grey_question:
Category Percentage Covered / Total
🟡 Statements
79.06% (+0.02% 🔼)
11627/14707
🔴 Branches
58.62% (+0.04% 🔼)
2849/4860
🟡 Functions
66.06% (+0.04% 🔼)
1859/2814
🟢 Lines
80.44% (+0.02% 🔼)
10482/13031

Test suite run success

1433 tests passing in 198 suites.

Report generated by 🧪jest coverage report action from 8b0d7847c424a5ec449e97d0b8eb2d1856d8d5fd