search

safe-global / safe-wallet-web

Safe{Wallet} – smart contract wallet for Ethereum (ex-Gnosis Safe multisig)
https://app.safe.global
GNU General Public License v3.0
336 stars 400 forks source link

Burger menu appears on welcome page and accounts page #3971

Closed jmealy closed 3 weeks ago

jmealy commented 1 month ago

Bug description

The burger menu is shown on screens where it should not be shown.

Edit: There was a ticket and PR for this previously but it wasn't fully fixed: #3897

Environment

Steps to reproduce

  1. Go to /welcome/accounts or /welcome
  2. Make the screen width smaller until the burger menu appears in the left of the header bar.

Expected result

There is no sidebar to show on these screens so the burger menu should not be shown.

Obtained result

Burger menu appears and redirects between the accounts page and the welcome page

Screenshots

image

usame-algan commented 1 month ago

Looks like #3897 didnt fully fix it.

MHarisAshfaq commented 1 month ago

I would like to take on the issue. Could you please assign it to me?

katspaugh commented 1 month ago

@MHarisAshfaq sure, go ahead 🙏

MHarisAshfaq commented 3 weeks ago

Hi @katspaugh, I am unable to reproduce this issue. It looks like this is already fixed. Screenshot 2024-08-12 at 6 12 20 PM

katspaugh commented 3 weeks ago

@MHarisAshfaq nice, closing the issue then. :) Thanks for checking!