safe-global / safe-wallet-web

Safe{Wallet} – smart account wallet
https://app.safe.global
GNU General Public License v3.0
365 stars 439 forks source link

Hide suspicious filter does not work beyond first page of transaction history #4005

Open jmealy opened 4 months ago

jmealy commented 4 months ago

Bug description

When you have loaded more than one page of the transaction history, toggling the hide suspicious button will only update the first page of results.

If you only load the first page, apply the filter, and then load more pages, it works as expected.

Environment

Steps to reproduce

  1. Find a safe with suspicious transactions on the first page and on any other page.
  2. Toggle the hide suspicious filter. The first page of results will be updated.
  3. Load more pages of results. They will be loaded according to the current position of the toggle is.
  4. Once more pages are loaded, try to apply the toggle again.

    Expected result

    Transactions should be updated according to the current value of the hide suspicious toggle, no matter what page they are on.

Obtained result

Transactions beyond page 1 are not updated.

liliya-soroka commented 2 weeks ago

existing 18.11.24