safebash / opencrypto

OpenCrypto is a lightweight JavaScript library built on top of WebCryptography API
MIT License
74 stars 23 forks source link

Node.js package #14

Open pantchox opened 3 years ago

pantchox commented 3 years ago

Hi, thanks for this great wrapper.

I think from node version 15.14.0 there is webcrypto in the official crytpo library. like so: require('crypto').webcrypto or using https://github.com/PeculiarVentures/webcrypto this might be a good idea to offer isomorphic package.

thanks!

jackHedaya commented 2 years ago

Hey there! Wondering if there are any updates on this as I was just about to build my own wrapper on top of opencrypto and the crypto package. Wouldn't mind taking a crack at it if it's not under development.

PeterBielak commented 2 years ago

Hi @pantchox thank you for the suggestion! It is very appreciated. Apologies for the late reply, I've been very busy during the last few months. I'd be glad to include this option. Feel free to open a PR.

jackHedaya commented 2 years ago

We have multiple options of going about this. @PeterBielak do you think the isomorphic-crypto package or a custom require('crypto') situation is better?

PeterBielak commented 2 years ago

@jackHedaya I'd prefer to build a custom solution as to prevent usage of any third party dependencies.

jackHedaya commented 2 years ago

So thinking we could use crypto.webcrypto but getting caught on the thought that it was only introduced in Node v12. Maybe we should use a shim but at that point we're using a 3rd party package anyways. Thoughts?