safebash / opencrypto

OpenCrypto is a lightweight JavaScript library built on top of WebCryptography API
MIT License
74 stars 23 forks source link

Types need to be overhauled #21

Closed jackHedaya closed 2 years ago

jackHedaya commented 2 years ago

Though the methods are offered in TypeScript, the parameters and return types are missing type signatures. I'm currently working on a PR but am probably going to need some help with certain parameters.

PeterBielak commented 2 years ago

Hi @jackHedaya, thank you very much for the contribution, it is very appreciated! Feel free to let me know if you have any and all questions.

jackHedaya commented 2 years ago

Think it's all good, managed by reading the lib code. PR should be ready to merge!