search

saferactive / trafficalmr

R package to support road safety and traffic calming measures
https://saferactive.github.io/trafficalmr/
GNU General Public License v3.0
5 stars 1 forks source link

Mainly tests, added curl as suggest, minor section in README #28

Closed layik closed 4 years ago

Robinlovelace commented 4 years ago

Looks good to me. One question: have you seen the new functionality in testthat 3.0.0?

https://rstudio.com/resources/webinars/testthat-3/

I'm not really sure what the benefits of this new way of doing things are but worth a look I reckon.

layik commented 4 years ago

@Robinlovelace, I had not seen it. Quick read does look like snapshot testing is the main addition and looks like backward compatible with local_edition(3).

Robinlovelace commented 4 years ago

:+1: probably overkill for our needs. Many thanks for adding tests!