search

safesparrow / fsharp

The F# compiler, F# core library, F# language service, and F# tooling integration for Visual Studio
https://dotnet.microsoft.com/languages/fsharp
MIT License
1 stars 0 forks source link

Handle module abbreviations better #23

Closed safesparrow closed 1 year ago

safesparrow commented 1 year ago

Currently when we see a module, we decide that the given file depends on all the previous files and all the files above it depend on it: https://github.com/safesparrow/fsharp/blob/ae0e40be4713c9b552d1478b5006cb2b3f13c560/tests/ParallelTypeCheckingTests/Code/DependencyResolution.fs#L161-L163

This is a safety we need without fully understanding the behaviour and implementing it.

This ticket is to avoid this defensive mechanism.

Also: module abbreviations in signature files are currently not supported, we should fix it: https://github.com/safesparrow/fsharp/blob/ae0e40be4713c9b552d1478b5006cb2b3f13c560/tests/ParallelTypeCheckingTests/Code/ASTVisit.fs#L1147

safesparrow commented 1 year ago

This is being handled in https://github.com/safesparrow/fsharp/pull/24