search

safety-data / akka-persistence-redis

Akka persistence plugin for Redis
Apache License 2.0
27 stars 13 forks source link

Sentinels as string #22

Closed herzrasen closed 6 years ago

herzrasen commented 6 years ago

This PR adds support for passing Redis Sentinels as a comma separated string of multiple host:port combinations. In our use case we need to be able to configure a dynamic list of sentinels and do not necessarily know how many instances we've got.

Would be great if you'd merge it back. Questions and/or improvements are welcome.

herzrasen commented 6 years ago

Thanks for your remarks @satabin. I updated the PR accordingly.

herzrasen commented 6 years ago

@satabin not sure what the failing test is about.

satabin commented 6 years ago

This timeout occurs from time to time, I never found what to do to make it go away, if this is due to a problem in the implementation or to sporadic latency in the travis infrastructure. After restarting the build, it passes. Thanks for this contribution.

satabin commented 6 years ago

Just published new 0.4.0-SNAPSHOT version with this change merged.