search

safety-orange / Imports-for-MPMB-s-Character-Sheet

Material for importing to MorePurpleMoreBetter's Character Record Sheet
158 stars 105 forks source link

Add Port Nyanzaru equipment #11

Closed Smashman closed 6 years ago

Smashman commented 6 years ago

Fixes #10.

Smashman commented 6 years ago

Hm, this doesn't appear to do work as expected..!

safety-orange commented 6 years ago

They work, but only after saving the sheet and opening it again do they appear in the menu. I see that MPMB has fixed this for the next version of the sheet on his GitHub.

The gearlist entries do need a source, so that they only show up if that source is included. If no source is listed, they will always be included and I think that is not what we want for these kind of additions :)

Smashman commented 6 years ago

I noticed that there's no 'equipment' menu in the source selection dialog.

Smashman commented 6 years ago

As discussed, I've added the Source.

I didn't include the source, as the syntax docs for Gear didn't include a source parameter. https://github.com/morepurplemorebetter/MPMBs-Character-Record-Sheet/blob/master/additional%20content%20syntax/Homebrew%20Syntax%20-%20GearList%20(adventuring%20gear).js

Cheers.

safety-orange commented 6 years ago

Great work, I merged it :)

I don't know why equipment isn't an option in the source selection dialog. Perhaps it was deemed not so necessary?

I also see that the syntax is missing this, I'll pass it along to MPMB!