search

safety-orange / Imports-for-MPMB-s-Character-Sheet

Material for importing to MorePurpleMoreBetter's Character Record Sheet
158 stars 105 forks source link

Use gulp for platform agnostic minification and concatenation #39

Closed Smashman closed 4 years ago

Smashman commented 4 years ago

This also removes superfluous iFileNames and RequiredSheetVersions

Smashman commented 4 years ago

The changes to the minified files look significant, this is due to the line end changes which will now remain consistent no matter which platform is used.

RobRoseKnows commented 4 years ago

Does minification yield any performance improvements? Because currently I personally don't see a need for it since the imports aren't served via the web.

Smashman commented 4 years ago

While I don't disagree, I am simply reimplementing the existing functionality using gulp to remove the PowerShell requirement.

They are sort of shared online via the reddit post, however.

safety-orange commented 4 years ago

Does minification yield any performance improvements? Because currently I personally don't see a need for it since the imports aren't served via the web.

I did some tests with the PDF and although the performance improvements after loading the PDF are indeed very small, opening the PDF with the scripted saved in it did go significantly faster. All in all, the difference is probably negligible. Your average smarthphone is still going to crash Adobe Acrobat Reader when trying to open this sheet with the script loaded.

Also, this way the PDF uses less space with the script loaded. That doesn't make any difference to me (what is 500 KB nowadays anyway?), but I have had numerous people complain about the size of these PDFs and I figured I could do my part to reduce its size a bit.

Smashman commented 4 years ago

This PR is still open, any issues precluding merge? Thanks