safety-orange / Imports-for-MPMB-s-Character-Sheet

Material for importing to MorePurpleMoreBetter's Character Record Sheet
158 stars 105 forks source link

Add Oversized Longbow to WDH #46

Closed BraabHimself closed 4 years ago

BraabHimself commented 4 years ago

Add Oversized Longbow and Oversized Arrow to WDH

Smashman commented 4 years ago

As with #45, I would recommend removing all minified files and simply commit WotC material/v13/pub_20180918_WDH.js

safety-orange commented 4 years ago

The description is very long and uses an abbreviation that isn't used anywhere else in the sheet "w/". I think the description of the weapon is better done as "Ammunition, heavy, two-handed; Damage uses Str instead of Dex; Requires Medium size and Str 18".

Also, the ability is set to Str, but it should be Dex, because all ranged weapon use Dex for the attack roll. Then there needs to be a modifiers to remove the Dex bonus and add the Str bonus to the damage.

WeaponsList["oversized longbow"] = {
    regExpSearch : /^(?=.*oversized?)(?=.*longbow).*$/i,
    name : "Oversized Longbow",
    source : ["WDH", 201],
    list : "ranged",
    ability : 4,
    type : "Martial",
    damage : [2, 6, "piercing"],
    range : "150/600 ft",
    weight : 2,
    description : "Ammunition, heavy, two-handed; Damage uses Str instead of Dex; Requires Medium size and Str 18",
    abilitytodamage : true,
    modifiers : ["", "Str-Dex"],
    ammo : "oversized arrow"
};

Unfortunately, this doesn't work if the weapon ever uses another ability score than Dex for its to hit. The sheet probably needs some extra functionality to make this weapon fully compatible.

BraabHimself commented 4 years ago

Ah, my bad.

I only did so under the advice of Smashman, unless I misunderstood him. I thought it was weird that I'd need to upload those additional minified files, as it would require you to inspect all of them.

BraabHimself commented 4 years ago

I somehow inadvertently closed this pull request. I don't know how I managed that.

On Wed, Jun 3, 2020 at 11:10 AM safety-orange notifications@github.com wrote:

The description is very long and uses an abbreviation that isn't used anywhere else in the sheet "w/". I think the description of the weapon is better done as "Ammunition, heavy, two-handed; Damage uses Str instead of Dex; Requires Medium size and Str 18".

Also, the ability is set to Str, but it should be Dex, because all ranged weapon use Dex for the attack roll. Then there needs to be a modifiers to remove the Dex bonus and add the Str bonus to the damage.

WeaponsList["oversized longbow"] = { regExpSearch : /^(?=.oversized?)(?=.longbow).*$/i, name : "Oversized Longbow", source : ["WDH", 201], list : "ranged", ability : 2, type : "Martial", damage : [2, 6, "piercing"], range : "150/600 ft", weight : 2, description : "Ammunition, heavy, two-handed; Damage uses Str instead of Dex; Requires Medium size and Str 18", abilitytodamage : true, modifiers : ["", "Str-Dex"], ammo : "oversized arrow"};

Unfortunately, this doesn't work if the weapon ever uses another ability score than Dex for its to hit. The sheet probably needs some extra functionality to make this weapon fully compatible.

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/safety-orange/Imports-for-MPMB-s-Character-Sheet/pull/46#issuecomment-638260566, or unsubscribe https://github.com/notifications/unsubscribe-auth/APAWHELO2NMJV7KW4WDXAG3RUZRVVANCNFSM4MXOWFFA .

safety-orange commented 4 years ago

It seems that you removed the oversized longbow now from your branch. All the files in your branch and mine are identical, so there is nothing to merge :)

Just make another commit with the changed pub_20180918_WDH.js file.