Fix issue where captures don't start after restarting from desktop mode

safijari / decky-recorder-fork

Other

47 stars 13 forks source link

Fix issue where captures don't start after restarting from desktop mode #14

Closed Ratismal closed 1 year ago

Ratismal commented 1 year ago

This PR does the following:

on psutil functions, try/except so that zombie processes don't crash the function
- Right now the except clause just passes, I'm not sure what a more elegant way to handle zombie processes is
On watchdog, capturing is killed when exiting gamemode. We also need to start capturing when re-entering gamemode

Fixes #8

safijari commented 1 year ago

I'm not sure how this works. Are you able to merge now that I've approved? If yes, please do so at your convenience. Otherwise let me know and I can merge.

Thank you for your pr

Ratismal commented 1 year ago

For anti-abuse reasons, only configured collaborators on a repository are able to do things such merge PRs, so merging it is something you'll have to do. I recommend doing a squash commit so that only one commit is made - the commit links back to the original PR for context, and you're left with a cleaner git commit history.