safijari / decky-recorder-fork

Other
48 stars 13 forks source link

Implement microphone recording #2

Open safijari opened 1 year ago

safijari commented 1 year ago

Copy of https://github.com/marissa999/decky-recorder/issues/13

TheAntVenom commented 1 year ago

Pls do, especially as a 2nd audio track.

SubstituteDoll commented 10 months ago

It would also be nice, like how NVidia ShadowPlay does it, for this recorder to be able to record microphone on a separate track than loopback audio. I assume this already uses FFMpeg, so it would just be as easy as saving the mic audio as another aac file and then appending it to the MP4 or MKV container using FFMpeg.

CoderMonkey1956 commented 2 weeks ago

@safijari Was this implemented? It isn't showing up on my decky recorder.

CoderMonkey1956 commented 2 weeks ago

@safijari Was this implemented? It isn't showing up on my decky recorder.

I'm not sure how pull requests work on GitHub

SubstituteDoll commented 2 weeks ago

@safijari Was this implemented? It isn't showing up on my decky recorder.

I'm not sure how pull requests work on GitHub

Do you mean you have a branch/fork where you implemented this? Do you have your repo hosted on GitHub? I don't see any repos under your GitHub account. Push it to GitHub, then make a pull request

safijari commented 2 weeks ago

I'm not actively developing recorder right now as the steam recording feature should be coming to stable soon and works better (and will have microphone recording in the future)

CoderMonkey1956 commented 2 weeks ago

@safijari Was this implemented? It isn't showing up on my decky recorder.

I'm not sure how pull requests work on GitHub

Do you mean you have a branch/fork where you implemented this? Do you have your repo hosted on GitHub? I don't see any repos under your GitHub account. Push it to GitHub, then make a pull request

I saw someone else made a pull request, and it got pushed to the main branch.

CoderMonkey1956 commented 2 weeks ago

I'm not actively developing recorder right now as the steam recording feature should be coming to stable soon and works better (and will have microphone recording in the future)

Ohhhh, thanks!