safing / portmaster-packaging

Portmaster packages and installers
GNU General Public License v3.0
49 stars 23 forks source link

Add rpm package #4

Closed dhaavi closed 2 years ago

dhaavi commented 4 years ago

Internal note: tracked by CC#1844.

shaurya-007 commented 3 years ago

Please make it available as a rpm, I guess its not that hard to package something differently, if it can be packaged as a deb it sure can be packaged as a rpm. Besides Safing would be missing out on a big chunk of its linux audience as much of the linux privacy crowd is either running debian or fedora and fedora users cant benefit from portmaster as its not available as a rpm package.

dhaavi commented 3 years ago

We are already planning to release an .rpm package.

It is, however, not that simple. Before we go about creating a CI process for an .rpm package, we are waiting for confirmation that the proposed fix in https://github.com/safing/docs/pull/26 works.

This is necessary, as the Portmaster would not even run out of the box if SELinux is enabled. Not all .rpm based distros have SELinux enabled, but with Fedora having it, we should definitely have this figured out before we proceed.

dhaavi commented 3 years ago

Thank you for showing support for an .rpm package and I would encourage anyone else who also wants this to chime in here so we can better estimate how many people are waiting for this.

shaurya-007 commented 3 years ago

Thanks for shedding light on the issue that is causing the delay, I fully understand that SElinux is a pain and you guys will have to look at the compatibility of portmaster with fedora before releasing anything. As for the new issue, I did not see that this one was already listed and when I did I commented here but forgot to close the one I made. Is there anything I can do to help with the rpm issue?

shaurya-007 commented 3 years ago

Also please try to have portmaster running in the SElinux enforcing mode.

shaurya-007 commented 3 years ago

We are already planning to release an .rpm package.

It is, however, not that simple. Before we go about creating a CI process for an .rpm package, we are waiting for confirmation that the proposed fix in safing/docs#26 works.

This is necessary, as the Portmaster would not even run out of the box if SELinux is enabled. Not all .rpm based distros have SELinux enabled, but with Fedora having it, we should definitely have this figured out before we proceed.

Now that it is confirmed that the fix works, any estimation when will an rpm package be available?

davegson commented 3 years ago

Hey @shaurya-007, thanks for you enthusiasm in regard to this feature request!

Even though one obstacle is out of the way, there still is a lot to do in order to realize this feature, like setting up CI, which is a lot of work in itself. As a result, this task is not an urgent priority for us and we are currently focusing our limited work-force elsewhere. It is likely months will pass until we get to it.

I understand this is a bummer to you, but for now I can only suggest you to install the Portmaster manually and follow the SELinux instructions which @northys so kindly tested and provided.

I hope this works as a good alternative in the meantime.

davegson commented 2 years ago

just a quick update, thanks to @ppacher's efforts, an .rpm package is now available - hope you all enjoy! https://safing.io/portmaster/#downloads https://docs.safing.io/portmaster/install/linux#installers

northys commented 2 years ago

@davegson @dhaavi hi guys, could we drop a note to doc for ppl who installed it manually? or do i just delete the portmaster folder and unit file and install the rpm?

dhaavi commented 2 years ago

Hey @northys, actually, just delete the unit and desktop files, as well as the updates folder. The installer will migrate from /var/lib/portmaster to the new location at /opt/safing/portmaster. If the installer detects a previous installation at /var/lib/portmaster that has not been uninstalled, it will abort.

northys commented 2 years ago

@dhaavi actually I have portmaster installed in /opt/portmaster should i rename it to /var/lib/portmaster after deleting files you've mentioned and run rpm install after that?

what does uninstalled mean? what does it check?

dhaavi commented 2 years ago

Ok, in that case just stop the Portmaster, delete the unit and desktop files and mv /opt/portmaster /opt/safing/portmaster, then install. The installation will be mostly a no-op, because the data is already there. It will just place the unit and desktop files.

what does uninstalled mean? what does it check?

It checks if /var/lib/portmaster/updates exists.

northys commented 2 years ago

Thanks it works even when I forgot to remove service file + desktop entries. So I had to uninstall the rpm and do the cleanup and installed it again. Still works. Thanks!