safing / portmaster-packaging

Portmaster packages and installers
GNU General Public License v3.0
49 stars 23 forks source link

Use rm -rf to delete updates dir #48

Closed kittkatter closed 2 years ago

kittkatter commented 3 years ago

What would you like to add or change?:

Post removal script for configs

hmm your post_remove() { echo "Removing portmaster modules" rm -f var/lib/portmaster/updates }

does not get executed by my manjaro machine

Removing portmaster modules rm: cannot remove 'var/lib/portmaster/updates': Is a directory error: command failed to execute correctly

change in the .INSTALL file with rm -rf as option fixes this. also go just rm -rf /var/lib/portmaster/ to get rid of old logs

Linux rm -rf ~/.config/Portmaster rm -rf /var/lib/portmaster

etc

Why do you and others need this?:

Imagine some changed settings , setup something wrong which he is not able to fix and just try's a fresh reinstall. The old configs are still stored and may be used in by the new install.

Useless waste of resources of the user and unclean uninstall

dhaavi commented 3 years ago

Hey @kittkatter, thanks for opening this issue.

rm -f var/lib/portmaster/updates rm: cannot remove 'var/lib/portmaster/updates': Is a directory

Thanks for pointing that out. We will fix this.


Currently, all data of the Portmaster lives in a single directory, /var/lib/portmaster. We started out with this directory, but will switch to /opt/safing/portmaster soon, as this is a much better fit for how we use it.

This main directory not only contains logs but also all the configuration and caches. If you purge remove the portmaster, that directory gets fully deleted.

Using ~/.config/ does not make sense, as the Portmaster is a system service and configuration is always global and not bound to any user.

ppacher commented 2 years ago

This has been resolved with our new PKGBUILD so I'm closing this one. If it's still an issue please just re-open.