davegson
commented
2 years ago Hey @DN-debug,
thank you a lot for your efforts in this great PR! However, I sadly have to inform you that you fell victim to a mess-up of ours:
When we started revamping all the linux installers one of our goals was to add support for the AUR. Some requirements for that, we thought, meant that we had to create a separate repository. Off we went and created that but as it turned out, we found solutions around the issues, meaning we did not need two separate repos.
We still continued our improvements on the other repo and planned to merge the changes into this repository a month ago, but then the SPN Alpha release required all our attention and here we are.
I am sorry that your efforts for this repo were fruitless. Again, that is totally on us! Daniel merged all our changes in #58 so at least this repo is up to date again.
If you still are willing we would love to hear your thoughts on & improvements for the updated files.
Have a good one, David
DN-debug
Hi Guys,
I believe the recent merge of #52 (portmaster.service file) broke the integrity and check fails on the existing PKGBUILD. I have updated the checksum and would always suggest calculating the checksum after any modification is done.
Simplified the source path -- when makepkg is run, it starts by looking into the same/current directory hence you may branch off of from the current instead of using "dot" in the relative path name.
Also suggesting the best practice to use of "Install" instead of "mkdir -p" as mentioned by Hugo in PR #47 ( Not added in my PR as he proposed it ahead of me )
Thanks!