safing / portmaster-packaging

Portmaster packages and installers
GNU General Public License v3.0
49 stars 23 forks source link

Not all sizes of icons for different desktops are created #93

Closed mattkeenan closed 10 months ago

mattkeenan commented 1 year ago

What happened:

When I installed the package the portmaster icon didn't appear in the workspace switcher (XFCE)

What did you expect to happen?:

The window preview icon to appear like other apps.

How did you reproduce it?:

Installed the package on 22.04 XUbuntu

Suggested Fix:

Provide app icons at the same sizes that Firefox uses. This would also include an SVG version of the icon; I got a copy from the safing website.

I'll post a PR shortly, and then edit this issue as I can't comment on issues without closing as I don't have permissions to add non closing comments.

Debug Information:

Icon files for only the following sizes exist in /usr/share/icons/hicolor

128x128/apps/portmaster.png
16x16/apps/portmaster.png
32x32/apps/portmaster.png
48x48/apps/portmaster.png
96x96/apps/portmaster.png

Compared to, for example, firefox

128x128/apps/firefox.png
16x16/apps/firefox.png
22x22/apps/firefox.png
24x24/apps/firefox.png
256x256/apps/firefox.png
32x32/apps/firefox.png
48x48/apps/firefox.png
64x64/apps/firefox.png
symbolic/apps/firefox-symbolic.svg
github-actions[bot] commented 1 year ago

This issue has been automatically marked as inactive because it has not had activity in the past two months.

If no further activity occurs, this issue will be automatically closed in one week in order to increase our focus on active topics.

dhaavi commented 1 year ago

Will be fixed by #95.

github-actions[bot] commented 10 months ago

This issue has been automatically marked as inactive because it has not had activity in the past two months.

If no further activity occurs, this issue will be automatically closed in one week in order to increase our focus on active topics.

github-actions[bot] commented 10 months ago

This issue has been automatically closed because it has not had recent activity. Thank you for your contributions.

If the issue has not been resolved, you can find more information in our Wiki or continue the conversation on our Discord.