2.2 Comments

[akashyap47]

Good job!

Even the little bit of UI work you put in makes things look a lot nicer than other implementations I've seen. Most of the features work. Especially liked the fact that each item had a page, from which I can specify how many of that item I want.

Some problems you might want to rectify for 2.3: (1) I can check out n items even though you don't have n items in your inventory. Moreover, when I do check out n items, you don't change the admin page to reflect the inventory changes. (2) Whenever I try to check stuff out as admin, the checkout button fails. (3) Zooming into an item page from the shopping cart fails. :(

Fine code, design/problem analysis.

[safreiberg]

Oof... my mistake on the zoom from shopping cart :(.

Just to clarify the inventory question: I thought about the inventory action, and I think that it falls outside the purview of the shopping cart application. Firstly, I think that the inventory should only change when the item has actually been moved from the warehouse (which this application can't verify, since it doesn't even know if the user paid correctly). Therefore I think that the inventory should be for the administrator, but not automatically updated without integration with a payment site.

Thanks!

[akashyap47]

Hm. Fair point. But we can still institute some checks that prevent really egregious checkout attempts right? Like, if there are 100 Free Willies (what?) in the inventory (and let's assume that's the most up-to-date inventory stat), if I place an order for 150 Free Willies, surely you can either prevent me from placing said order or automatically reduce my order to only 100 Free Willies. There's definitely a middle ground here. But yes, good point.

[safreiberg]

Okay I'll continue to look at it. Are you using a@a.com? If you use a live email address, you'll get email confirmations of purchases :).

[akashyap47]

Haha, yes, a@a.com is me. But good to know--I'll be sure to use an actual email when testing your 2.3! :D