search

safreiberg / saf_proj2

0 stars 0 forks source link

2.3 Comments #7

Open akashyap47 opened 12 years ago

akashyap47 commented 12 years ago

FEEDBACK:

Design Analysis -

Need to do a better job here. You list a set of design challenges but then the 'details' section doesn't thoroughly or clearly address each one. For example, the first paragraph in the 'details' section does not clearly relate to the design challenges you present. Ensure that for each design challenge you mention, you establish what the possible solutions to that challenge are and what the advantages/disads of those solutions are and then how you picked a solution.

Problem Analysis -

Good. Clarity here is great.

Functionality -

Super solid. Two confusing things: (1) Lists that 'Guest' make private are viewable to all other 'Guests'. This is weird? (2) Why can't I add multiple things to the wishlist? :(

Very thorough unit tests.

safreiberg commented 12 years ago

One thing about the functionality: Guests are identified by IP address, so that Carts can persist through a session and even through multiple sessions as long as the user has the same IP. Wishlists behave the same way, so if your multiple "guests" were on the same IP then they would all have access to the same wishlist.

Sorry about the multiple add problems! I hadn't noticed that locally.

I will make sure to redo the Design Analysis for final submission.

Thanks! Stephen