search

safwanrahman / django-webpush

Web Push Notification Package for Django
GNU General Public License v3.0
371 stars 107 forks source link

Support for Django 4.1 #124

Closed clearminds closed 10 months ago

clearminds commented 1 year ago

contextfunction has been renamed to pass_context

safwanrahman commented 1 year ago

@clearminds Can you make it backward compitable?

clearminds commented 1 year ago

no clue how that is going to be possible to do since it is a decorator :/

clearminds commented 1 year ago

@safwanrahman ok, should be updated now with code that is backwards compatible

clearminds commented 10 months ago

@safwanrahman should I give up on using this library and move to something else?

drien commented 10 months ago

I forked and made these same changes myself before seeing this PR, everything seems to work properly.

I also removed the unused arrow import, since it's not actually used anywhere and not declared as a dependency.

safwanrahman commented 10 months ago

Sorry for not looking into this. I have merged it, thanks @clearminds