safx / Emoji-Swift

String extension converting to and from emoji character and Emoji-One
MIT License
127 stars 38 forks source link

Upgraded emoji list and improved performances #17

Closed ipodishima closed 5 years ago

ipodishima commented 5 years ago

Hey there

Not sure this repo is still maintained, but I needed some updates for a project of mine.

What's new in this upgrade:

I'm all ears

codecov-io commented 5 years ago

Codecov Report

Merging #17 into master will not change coverage. The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff            @@
##           master     #17      +/-   ##
=========================================
  Coverage     100%    100%              
=========================================
  Files           3       2       -1     
  Lines         109   14430   +14321     
=========================================
+ Hits          109   14430   +14321
Impacted Files Coverage Δ
Sources/Emoji.swift 100% <ø> (ø) :arrow_up:
Sources/String+Emoji.swift 100% <100%> (ø) :arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update ae772e9...eb8b6c4. Read the comment docs.

safx commented 5 years ago

It looks nice😍, though we lose custom emoji feature. Thanks!

ipodishima commented 5 years ago

You're very welcome! Yeah, I wasn't sure about the use of custom emojis but the speed improvement was so huge it was worth it for my project :)