search

saga-project / bliss

ATTENTION: bliss is now saga-python. Please check out the new project website for the latest version: http://saga-project.github.com/saga-python/
http://saga-project.github.com/saga-python/
Other
8 stars 4 forks source link

unnecessary log messages for ssh plugin #51

Open pradeepmantha opened 12 years ago

pradeepmantha commented 12 years ago

The below messages are not needed for XSEDE tutorial.

05/25/2012 08:30:33 PM - SSHJobPlugin(0xeb5efc8) - WARNING - Silently ignoring the walltime_limit attribute. It's not supported by SSH. 05/25/2012 08:30:33 PM - SSHJobPlugin(0xeb5efc8) - WARNING - Silently ignoring the total_cpu_count attribute. It's not supported by SSH. 05/25/2012 08:30:33 PM - SSHJobPlugin(0xeb5efc8) - WARNING - Silently ignoring the spmd_variation attribute. It's not supported by SSH.

andre-merzky commented 12 years ago

Aren't those messages only visible when SAGA_VERBOSE is set? ::

self.pi.log_warning("Silently ignoring the walltime_limit attribute. It's not supported by SSH.")

But, FWIW, job description attributes should never be silently ignored: if they are specified, then they are likely specified for a reason, and not honoring them will likely cause the application to misbehave.

My $0.02,

Andre.

pradeepmantha commented 12 years ago

Yes! The SAGA_VERBOSE is not set and still I see these messages.

On Sat, May 26, 2012 at 8:01 AM, Andre Merzky reply@reply.github.com wrote:

Aren't those messages only visible when SAGA_VERBOSE is set? ::

   self.pi.log_warning("Silently ignoring the walltime_limit attribute. It's not supported by SSH.")

But, FWIW, job description attributes should never be silently ignored: if they are specified, then they are likely specified for a reason, and not honoring them will likely cause the application to misbehave.

My $0.02,

 Andre.

Reply to this email directly or view it on GitHub: https://github.com/saga-project/bliss/issues/51#issuecomment-5946773

oweidner commented 12 years ago

Pradeep,

this has been fixed in MASTER a while ago? Let me know if not.

Cheers, Ole

On May 25, 2012, at 8:36 PM, pradeepmantha wrote:

The below messages are not needed for XSEDE tutorial.

05/25/2012 08:30:33 PM - SSHJobPlugin(0xeb5efc8) - WARNING - Silently ignoring the walltime_limit attribute. It's not supported by SSH. 05/25/2012 08:30:33 PM - SSHJobPlugin(0xeb5efc8) - WARNING - Silently ignoring the total_cpu_count attribute. It's not supported by SSH. 05/25/2012 08:30:33 PM - SSHJobPlugin(0xeb5efc8) - WARNING - Silently ignoring the spmd_variation attribute. It's not supported by SSH.

Reply to this email directly or view it on GitHub: https://github.com/saga-project/bliss/issues/51

oweidner commented 12 years ago

I can make these "DEBUG" messages instead of "WARNING", so they only show up with SAGA_VERBOSE=5 or higher.

andre-merzky commented 11 years ago

Silently ignoring job attributes is not good -- if the attribs are specified, they are so for a reason...::

merzky@thinkie:~/saga/bliss (master $%) $ ack 'Silently ignoring'
bliss/plugins/ssh/process.py
27:            self.pi.log_debug("Silently ignoring the walltime_limit attribute. It's not supported by SSH.")
30:            self.pi.log_debug("Silently ignoring the total_cpu_count attribute. It's not supported by SSH.")
33:            self.pi.log_debug("Silently ignoring the number_of_processes attribute. It's not supported by SSH.")
36:            self.pi.log_debug("Silently ignoring the spmd_variation attribute. It's not supported by SSH.")
39:            self.pi.log_debug("Silently ignoring the project attribute. It's not supported by SSH.")
42:            self.pi.log_debug("Silently ignoring the queue attribute. It's not supported by SSH.")