[Accessibility] Add aria-controls

sagalbot / vue-select

Everything you wish the HTML <select> element could do, wrapped up into a lightweight, extensible Vue component.

https://vue-select.org

MIT License

4.65k stars 1.34k forks source link

[Accessibility] Add aria-controls #1798

Open damian-krupa opened 1 year ago

damian-krupa commented 1 year ago

I am using an automated accessibility testing tool called Level Access Assistant. It shows an issue for Select.vue component - aria-controls attribute is lacking.

Describe the solution you'd like add this line of code :aria-controls="vs${uid}__listbox" in the Select.vue combobox div, right under aria-owns

Additional context Error message: This DIV (role=combobox) must have all of the following attributes: aria-controls | aria-expanded

damian-krupa commented 1 year ago

I have opened a PR some time ago to fix this. Please take a look, it's a one-liner https://github.com/sagalbot/vue-select/pull/1802

legostud commented 5 months ago

That looks like the same bug that I'm running into with my audit.