sagamusix / JDTools

Patch conversion utility for Roland JD-800 / JD-990 and compatibles
Other
46 stars 5 forks source link

Initialization list in constexpr constructors and cstring #9

Closed dimatura closed 1 year ago

dimatura commented 1 year ago

I was having issues with compiling JDTools with g++ 9.4 in Ubuntu 20.04. It didn't accept the constructors for uint16le and uint32le in constexpr expressions, until I changed them to use initializer lists.

It also did not find memcmp in Utils.hpp, so I added an include for <cstring>.

With these changes it compiles and appears to be working ok.

Thanks for the great work!