Potential issue in src/google/protobuf/util/internal/protostream_objectsource.cc: Unchecked return from initialization function

What is a Conditionally Uninitialized Variable? The return value of a function that is potentially used to initialize a local variable is not checked. Therefore, reading the local variable may result in undefined behavior.

40 instances of this defect were found in the following locations:

Instance 1 File : src/google/protobuf/util/internal/protostream_objectsource.cc Enclosing Function : RenderMap@ProtoStreamObjectSource@converter@util@protobuf@google Function : ReadVarint32@CodedInputStream@io@protobuf@google https://github.com/sagarpant1/protobuf/blob/6b1d0f11493ef2317ea74aa00804835a10ebaf19/src/google/protobuf/util/internal/protostream_objectsource.cc#L285 Issue in: buffer32

Code extract:

  do {
    // Render map entry message type.
    uint32 buffer32;
    stream_->ReadVarint32(&buffer32);  // message length <------ HERE
    int old_limit = stream_->PushLimit(buffer32);
    std::string map_key;

How can I fix it? Fix provided in corresponding Pull Request.

Instance 2 File : src/google/protobuf/util/internal/protostream_objectsource.cc Enclosing Function : RenderPacked@ProtoStreamObjectSource@converter@util@protobuf@google Function : ReadVarint32@CodedInputStream@io@protobuf@google https://github.com/sagarpant1/protobuf/blob/6b1d0f11493ef2317ea74aa00804835a10ebaf19/src/google/protobuf/util/internal/protostream_objectsource.cc#L325 Issue in: length

Code extract:

Status ProtoStreamObjectSource::RenderPacked(
    const google::protobuf::Field* field, ObjectWriter* ow) const {
  uint32 length;
  stream_->ReadVarint32(&length); <------ HERE
  int old_limit = stream_->PushLimit(length);
  while (stream_->BytesUntilLimit() > 0) {

How can I fix it? Fix provided in corresponding Pull Request.

Instance 3 File : src/google/protobuf/util/internal/protostream_objectsource.cc Enclosing Function : RenderString@ProtoStreamObjectSource@converter@util@protobuf@google Function : ReadVarint32@CodedInputStream@io@protobuf@google https://github.com/sagarpant1/protobuf/blob/6b1d0f11493ef2317ea74aa00804835a10ebaf19/src/google/protobuf/util/internal/protostream_objectsource.cc#L507 Issue in: buffer32

Code extract:

  uint32 buffer32;
  std::string str;  // default value of empty for String wrapper
  if (tag != 0) {
    os->stream_->ReadVarint32(&buffer32);  // string size. <------ HERE
    os->stream_->ReadString(&str, buffer32);
    os->stream_->ReadTag();

How can I fix it? Fix provided in corresponding Pull Request.

Instance 4 File : src/google/protobuf/util/internal/protostream_objectsource.cc Enclosing Function : RenderBytes@ProtoStreamObjectSource@converter@util@protobuf@google Function : ReadVarint32@CodedInputStream@io@protobuf@google https://github.com/sagarpant1/protobuf/blob/6b1d0f11493ef2317ea74aa00804835a10ebaf19/src/google/protobuf/util/internal/protostream_objectsource.cc#L523 Issue in: buffer32

Code extract:

  uint32 buffer32;
  std::string str;
  if (tag != 0) {
    os->stream_->ReadVarint32(&buffer32); <------ HERE
    os->stream_->ReadString(&str, buffer32);
    os->stream_->ReadTag();

How can I fix it? Fix provided in corresponding Pull Request.

Instance 5 File : src/google/protobuf/util/internal/protostream_objectsource.cc Enclosing Function : RenderAny@ProtoStreamObjectSource@converter@util@protobuf@google Function : ReadVarint32@CodedInputStream@io@protobuf@google https://github.com/sagarpant1/protobuf/blob/6b1d0f11493ef2317ea74aa00804835a10ebaf19/src/google/protobuf/util/internal/protostream_objectsource.cc#L617 Issue in: _type_urlsize

Code extract:

    if (field->number() == 1) {
      // read type_url
      uint32 type_url_size;
      os->stream_->ReadVarint32(&type_url_size); <------ HERE
      os->stream_->ReadString(&type_url, type_url_size);
    } else if (field->number() == 2) {

How can I fix it? Fix provided in corresponding Pull Request.

Instance 6 File : src/google/protobuf/util/internal/protostream_objectsource.cc Enclosing Function : RenderAny@ProtoStreamObjectSource@converter@util@protobuf@google Function : ReadVarint32@CodedInputStream@io@protobuf@google https://github.com/sagarpant1/protobuf/blob/6b1d0f11493ef2317ea74aa00804835a10ebaf19/src/google/protobuf/util/internal/protostream_objectsource.cc#L622 Issue in: _valuesize

Code extract:

    } else if (field->number() == 2) {
      // read value
      uint32 value_size;
      os->stream_->ReadVarint32(&value_size); <------ HERE
      os->stream_->ReadString(&value, value_size);
    }

How can I fix it? Fix provided in corresponding Pull Request.

Instance 7 File : src/google/protobuf/util/internal/protostream_objectsource.cc Enclosing Function : RenderFieldMask@ProtoStreamObjectSource@converter@util@protobuf@google Function : ReadVarint32@CodedInputStream@io@protobuf@google https://github.com/sagarpant1/protobuf/blob/6b1d0f11493ef2317ea74aa00804835a10ebaf19/src/google/protobuf/util/internal/protostream_objectsource.cc#L699 Issue in: buffer32

Code extract:

                          "Invalid FieldMask, unexpected field.");
    }
    std::string str;
    os->stream_->ReadVarint32(&buffer32);  // string size. <------ HERE
    os->stream_->ReadString(&str, buffer32);
    if (!combined.empty()) {

How can I fix it? Fix provided in corresponding Pull Request.

Instance 8 File : src/google/protobuf/util/internal/protostream_objectsource.cc Enclosing Function : RenderField@ProtoStreamObjectSource@converter@util@protobuf@google Function : ReadVarint32@CodedInputStream@io@protobuf@google https://github.com/sagarpant1/protobuf/blob/6b1d0f11493ef2317ea74aa00804835a10ebaf19/src/google/protobuf/util/internal/protostream_objectsource.cc#L774 Issue in: buffer32

Code extract:

  // message small in order to preserve stack space and not crash.
  if (field->kind() == google::protobuf::Field::TYPE_MESSAGE) {
    uint32 buffer32;
    stream_->ReadVarint32(&buffer32);  // message length <------ HERE
    int old_limit = stream_->PushLimit(buffer32);
    // Get the nested message type for this field.

How can I fix it? Fix provided in corresponding Pull Request.

Instance 9 File : src/google/protobuf/util/internal/protostream_objectsource.cc Enclosing Function : RenderNonMessageField@ProtoStreamObjectSource@converter@util@protobuf@google Function : ReadVarint64@CodedInputStream@io@protobuf@google https://github.com/sagarpant1/protobuf/blob/6b1d0f11493ef2317ea74aa00804835a10ebaf19/src/google/protobuf/util/internal/protostream_objectsource.cc#L818 Issue in: buffer64

Code extract:

  std::string strbuffer;
  switch (field->kind()) {
    case google::protobuf::Field::TYPE_BOOL: {
      stream_->ReadVarint64(&buffer64); <------ HERE
      ow->RenderBool(field_name, buffer64 != 0);
      break;

How can I fix it? Fix provided in corresponding Pull Request.

Instance 10 File : src/google/protobuf/util/internal/protostream_objectsource.cc Enclosing Function : RenderNonMessageField@ProtoStreamObjectSource@converter@util@protobuf@google Function : ReadVarint32@CodedInputStream@io@protobuf@google https://github.com/sagarpant1/protobuf/blob/6b1d0f11493ef2317ea74aa00804835a10ebaf19/src/google/protobuf/util/internal/protostream_objectsource.cc#L823 Issue in: buffer32

Code extract:

      break;
    }
    case google::protobuf::Field::TYPE_INT32: {
      stream_->ReadVarint32(&buffer32); <------ HERE
      ow->RenderInt32(field_name, bit_cast<int32>(buffer32));
      break;

How can I fix it? Fix provided in corresponding Pull Request.

Instance 11 File : src/google/protobuf/util/internal/protostream_objectsource.cc Enclosing Function : RenderNonMessageField@ProtoStreamObjectSource@converter@util@protobuf@google Function : ReadVarint64@CodedInputStream@io@protobuf@google https://github.com/sagarpant1/protobuf/blob/6b1d0f11493ef2317ea74aa00804835a10ebaf19/src/google/protobuf/util/internal/protostream_objectsource.cc#L828 Issue in: buffer64

Code extract:

      break;
    }
    case google::protobuf::Field::TYPE_INT64: {
      stream_->ReadVarint64(&buffer64); <------ HERE
      ow->RenderInt64(field_name, bit_cast<int64>(buffer64));
      break;

How can I fix it? Correct reference usage found in src/google/protobuf/io/coded_stream.cc at line 527. https://github.com/sagarpant1/protobuf/blob/6b1d0f11493ef2317ea74aa00804835a10ebaf19/src/google/protobuf/io/coded_stream.cc#L527 Code extract:

  // For the slow path, just do a 64-bit read. Try to optimize for one-byte tags
  // again, since we have now refreshed the buffer.
  uint64 result = 0;
  if (!ReadVarint64(&result)) return 0; <------ HERE
  return static_cast<uint32>(result);
}

Instance 12 File : src/google/protobuf/util/internal/protostream_objectsource.cc Enclosing Function : RenderNonMessageField@ProtoStreamObjectSource@converter@util@protobuf@google Function : ReadVarint32@CodedInputStream@io@protobuf@google https://github.com/sagarpant1/protobuf/blob/6b1d0f11493ef2317ea74aa00804835a10ebaf19/src/google/protobuf/util/internal/protostream_objectsource.cc#L833 Issue in: buffer32

Code extract:

      break;
    }
    case google::protobuf::Field::TYPE_UINT32: {
      stream_->ReadVarint32(&buffer32); <------ HERE
      ow->RenderUint32(field_name, bit_cast<uint32>(buffer32));
      break;

How can I fix it? Correct reference usage found in src/google/protobuf/util/delimited_message_util.cc at line 72. https://github.com/sagarpant1/protobuf/blob/6b1d0f11493ef2317ea74aa00804835a10ebaf19/src/google/protobuf/util/delimited_message_util.cc#L72 Code extract:


  // Read the size.
  uint32 size;
  if (!input->ReadVarint32(&size)) { <------ HERE
    if (clean_eof != NULL) *clean_eof = input->CurrentPosition() == start;
    return false;

Instance 13 File : src/google/protobuf/util/internal/protostream_objectsource.cc Enclosing Function : RenderNonMessageField@ProtoStreamObjectSource@converter@util@protobuf@google Function : ReadVarint64@CodedInputStream@io@protobuf@google https://github.com/sagarpant1/protobuf/blob/6b1d0f11493ef2317ea74aa00804835a10ebaf19/src/google/protobuf/util/internal/protostream_objectsource.cc#L838 Issue in: buffer64

Code extract:

      break;
    }
    case google::protobuf::Field::TYPE_UINT64: {
      stream_->ReadVarint64(&buffer64); <------ HERE
      ow->RenderUint64(field_name, bit_cast<uint64>(buffer64));
      break;

  // For the slow path, just do a 64-bit read. Try to optimize for one-byte tags
  // again, since we have now refreshed the buffer.
  uint64 result = 0;
  if (!ReadVarint64(&result)) return 0; <------ HERE
  return static_cast<uint32>(result);
}

Instance 14 File : src/google/protobuf/util/internal/protostream_objectsource.cc Enclosing Function : RenderNonMessageField@ProtoStreamObjectSource@converter@util@protobuf@google Function : ReadVarint32@CodedInputStream@io@protobuf@google https://github.com/sagarpant1/protobuf/blob/6b1d0f11493ef2317ea74aa00804835a10ebaf19/src/google/protobuf/util/internal/protostream_objectsource.cc#L843 Issue in: buffer32

Code extract:

      break;
    }
    case google::protobuf::Field::TYPE_SINT32: {
      stream_->ReadVarint32(&buffer32); <------ HERE
      ow->RenderInt32(field_name, WireFormatLite::ZigZagDecode32(buffer32));
      break;


  // Read the size.
  uint32 size;
  if (!input->ReadVarint32(&size)) { <------ HERE
    if (clean_eof != NULL) *clean_eof = input->CurrentPosition() == start;
    return false;

Instance 15 File : src/google/protobuf/util/internal/protostream_objectsource.cc Enclosing Function : RenderNonMessageField@ProtoStreamObjectSource@converter@util@protobuf@google Function : ReadVarint64@CodedInputStream@io@protobuf@google https://github.com/sagarpant1/protobuf/blob/6b1d0f11493ef2317ea74aa00804835a10ebaf19/src/google/protobuf/util/internal/protostream_objectsource.cc#L848 Issue in: buffer64

Code extract:

      break;
    }
    case google::protobuf::Field::TYPE_SINT64: {
      stream_->ReadVarint64(&buffer64); <------ HERE
      ow->RenderInt64(field_name, WireFormatLite::ZigZagDecode64(buffer64));
      break;

  // For the slow path, just do a 64-bit read. Try to optimize for one-byte tags
  // again, since we have now refreshed the buffer.
  uint64 result = 0;
  if (!ReadVarint64(&result)) return 0; <------ HERE
  return static_cast<uint32>(result);
}

Instance 16 File : src/google/protobuf/util/internal/protostream_objectsource.cc Enclosing Function : RenderNonMessageField@ProtoStreamObjectSource@converter@util@protobuf@google Function : ReadLittleEndian32@CodedInputStream@io@protobuf@google https://github.com/sagarpant1/protobuf/blob/6b1d0f11493ef2317ea74aa00804835a10ebaf19/src/google/protobuf/util/internal/protostream_objectsource.cc#L853 Issue in: buffer32

Code extract:

      break;
    }
    case google::protobuf::Field::TYPE_SFIXED32: {
      stream_->ReadLittleEndian32(&buffer32); <------ HERE
      ow->RenderInt32(field_name, bit_cast<int32>(buffer32));
      break;

How can I fix it? Correct reference usage found in src/google/protobuf/wire_format_lite.cc at line 217. https://github.com/sagarpant1/protobuf/blob/6b1d0f11493ef2317ea74aa00804835a10ebaf19/src/google/protobuf/wire_format_lite.cc#L217 Code extract:

    }
    case WireFormatLite::WIRETYPE_FIXED32: {
      uint32 value;
      if (!input->ReadLittleEndian32(&value)) return false; <------ HERE
      output->WriteVarint32(tag);
      output->WriteLittleEndian32(value);

Instance 17 File : src/google/protobuf/util/internal/protostream_objectsource.cc Enclosing Function : RenderNonMessageField@ProtoStreamObjectSource@converter@util@protobuf@google Function : ReadLittleEndian64@CodedInputStream@io@protobuf@google https://github.com/sagarpant1/protobuf/blob/6b1d0f11493ef2317ea74aa00804835a10ebaf19/src/google/protobuf/util/internal/protostream_objectsource.cc#L858 Issue in: buffer64

Code extract:

      break;
    }
    case google::protobuf::Field::TYPE_SFIXED64: {
      stream_->ReadLittleEndian64(&buffer64); <------ HERE
      ow->RenderInt64(field_name, bit_cast<int64>(buffer64));
      break;

How can I fix it? Correct reference usage found in src/google/protobuf/wire_format_lite.cc at line 183. https://github.com/sagarpant1/protobuf/blob/6b1d0f11493ef2317ea74aa00804835a10ebaf19/src/google/protobuf/wire_format_lite.cc#L183 Code extract:

    }
    case WireFormatLite::WIRETYPE_FIXED64: {
      uint64 value;
      if (!input->ReadLittleEndian64(&value)) return false; <------ HERE
      output->WriteVarint32(tag);
      output->WriteLittleEndian64(value);

Instance 18 File : src/google/protobuf/util/internal/protostream_objectsource.cc Enclosing Function : RenderNonMessageField@ProtoStreamObjectSource@converter@util@protobuf@google Function : ReadLittleEndian32@CodedInputStream@io@protobuf@google https://github.com/sagarpant1/protobuf/blob/6b1d0f11493ef2317ea74aa00804835a10ebaf19/src/google/protobuf/util/internal/protostream_objectsource.cc#L863 Issue in: buffer32

Code extract:

      break;
    }
    case google::protobuf::Field::TYPE_FIXED32: {
      stream_->ReadLittleEndian32(&buffer32); <------ HERE
      ow->RenderUint32(field_name, bit_cast<uint32>(buffer32));
      break;

    }
    case WireFormatLite::WIRETYPE_FIXED32: {
      uint32 value;
      if (!input->ReadLittleEndian32(&value)) return false; <------ HERE
      output->WriteVarint32(tag);
      output->WriteLittleEndian32(value);

Instance 19 File : src/google/protobuf/util/internal/protostream_objectsource.cc Enclosing Function : RenderNonMessageField@ProtoStreamObjectSource@converter@util@protobuf@google Function : ReadLittleEndian64@CodedInputStream@io@protobuf@google https://github.com/sagarpant1/protobuf/blob/6b1d0f11493ef2317ea74aa00804835a10ebaf19/src/google/protobuf/util/internal/protostream_objectsource.cc#L868 Issue in: buffer64

Code extract:

      break;
    }
    case google::protobuf::Field::TYPE_FIXED64: {
      stream_->ReadLittleEndian64(&buffer64); <------ HERE
      ow->RenderUint64(field_name, bit_cast<uint64>(buffer64));
      break;

    }
    case WireFormatLite::WIRETYPE_FIXED64: {
      uint64 value;
      if (!input->ReadLittleEndian64(&value)) return false; <------ HERE
      output->WriteVarint32(tag);
      output->WriteLittleEndian64(value);

Instance 20 File : src/google/protobuf/util/internal/protostream_objectsource.cc Enclosing Function : RenderNonMessageField@ProtoStreamObjectSource@converter@util@protobuf@google Function : ReadLittleEndian32@CodedInputStream@io@protobuf@google https://github.com/sagarpant1/protobuf/blob/6b1d0f11493ef2317ea74aa00804835a10ebaf19/src/google/protobuf/util/internal/protostream_objectsource.cc#L873 Issue in: buffer32

Code extract:

      break;
    }
    case google::protobuf::Field::TYPE_FLOAT: {
      stream_->ReadLittleEndian32(&buffer32); <------ HERE
      ow->RenderFloat(field_name, bit_cast<float>(buffer32));
      break;

    }
    case WireFormatLite::WIRETYPE_FIXED32: {
      uint32 value;
      if (!input->ReadLittleEndian32(&value)) return false; <------ HERE
      output->WriteVarint32(tag);
      output->WriteLittleEndian32(value);

Instance 21 File : src/google/protobuf/util/internal/protostream_objectsource.cc Enclosing Function : RenderNonMessageField@ProtoStreamObjectSource@converter@util@protobuf@google Function : ReadLittleEndian64@CodedInputStream@io@protobuf@google https://github.com/sagarpant1/protobuf/blob/6b1d0f11493ef2317ea74aa00804835a10ebaf19/src/google/protobuf/util/internal/protostream_objectsource.cc#L878 Issue in: buffer64

Code extract:

      break;
    }
    case google::protobuf::Field::TYPE_DOUBLE: {
      stream_->ReadLittleEndian64(&buffer64); <------ HERE
      ow->RenderDouble(field_name, bit_cast<double>(buffer64));
      break;

    }
    case WireFormatLite::WIRETYPE_FIXED64: {
      uint64 value;
      if (!input->ReadLittleEndian64(&value)) return false; <------ HERE
      output->WriteVarint32(tag);
      output->WriteLittleEndian64(value);

Instance 22 File : src/google/protobuf/util/internal/protostream_objectsource.cc Enclosing Function : RenderNonMessageField@ProtoStreamObjectSource@converter@util@protobuf@google Function : ReadVarint32@CodedInputStream@io@protobuf@google https://github.com/sagarpant1/protobuf/blob/6b1d0f11493ef2317ea74aa00804835a10ebaf19/src/google/protobuf/util/internal/protostream_objectsource.cc#L883 Issue in: buffer32

Code extract:

      break;
    }
    case google::protobuf::Field::TYPE_ENUM: {
      stream_->ReadVarint32(&buffer32); <------ HERE

      // If the field represents an explicit NULL value, render null.


  // Read the size.
  uint32 size;
  if (!input->ReadVarint32(&size)) { <------ HERE
    if (clean_eof != NULL) *clean_eof = input->CurrentPosition() == start;
    return false;

Instance 23 File : src/google/protobuf/util/internal/protostream_objectsource.cc Enclosing Function : RenderNonMessageField@ProtoStreamObjectSource@converter@util@protobuf@google Function : ReadVarint32@CodedInputStream@io@protobuf@google https://github.com/sagarpant1/protobuf/blob/6b1d0f11493ef2317ea74aa00804835a10ebaf19/src/google/protobuf/util/internal/protostream_objectsource.cc#L919 Issue in: buffer32

Code extract:

      break;
    }
    case google::protobuf::Field::TYPE_STRING: {
      stream_->ReadVarint32(&buffer32);  // string size. <------ HERE
      stream_->ReadString(&strbuffer, buffer32);
      ow->RenderString(field_name, strbuffer);


  // Read the size.
  uint32 size;
  if (!input->ReadVarint32(&size)) { <------ HERE
    if (clean_eof != NULL) *clean_eof = input->CurrentPosition() == start;
    return false;

Instance 24 File : src/google/protobuf/util/internal/protostream_objectsource.cc Enclosing Function : RenderNonMessageField@ProtoStreamObjectSource@converter@util@protobuf@google Function : ReadVarint32@CodedInputStream@io@protobuf@google https://github.com/sagarpant1/protobuf/blob/6b1d0f11493ef2317ea74aa00804835a10ebaf19/src/google/protobuf/util/internal/protostream_objectsource.cc#L925 Issue in: buffer32

Code extract:

      break;
    }
    case google::protobuf::Field::TYPE_BYTES: {
      stream_->ReadVarint32(&buffer32);  // bytes size. <------ HERE
      stream_->ReadString(&strbuffer, buffer32);
      ow->RenderBytes(field_name, strbuffer);


  // Read the size.
  uint32 size;
  if (!input->ReadVarint32(&size)) { <------ HERE
    if (clean_eof != NULL) *clean_eof = input->CurrentPosition() == start;
    return false;

Instance 25 File : src/google/protobuf/util/internal/protostream_objectsource.cc Enclosing Function : ReadFieldValueAsString@ProtoStreamObjectSource@converter@util@protobuf@google Function : ReadVarint64@CodedInputStream@io@protobuf@google https://github.com/sagarpant1/protobuf/blob/6b1d0f11493ef2317ea74aa00804835a10ebaf19/src/google/protobuf/util/internal/protostream_objectsource.cc#L943 Issue in: buffer64

Code extract:

  switch (field.kind()) {
    case google::protobuf::Field::TYPE_BOOL: {
      uint64 buffer64;
      stream_->ReadVarint64(&buffer64); <------ HERE
      result = buffer64 != 0 ? "true" : "false";
      break;

How can I fix it? Fix provided in corresponding Pull Request.

Instance 26 File : src/google/protobuf/util/internal/protostream_objectsource.cc Enclosing Function : ReadFieldValueAsString@ProtoStreamObjectSource@converter@util@protobuf@google Function : ReadVarint32@CodedInputStream@io@protobuf@google https://github.com/sagarpant1/protobuf/blob/6b1d0f11493ef2317ea74aa00804835a10ebaf19/src/google/protobuf/util/internal/protostream_objectsource.cc#L949 Issue in: buffer32

Code extract:

    }
    case google::protobuf::Field::TYPE_INT32: {
      uint32 buffer32;
      stream_->ReadVarint32(&buffer32); <------ HERE
      result = StrCat(bit_cast<int32>(buffer32));
      break;

How can I fix it? Fix provided in corresponding Pull Request.

Instance 27 File : src/google/protobuf/util/internal/protostream_objectsource.cc Enclosing Function : ReadFieldValueAsString@ProtoStreamObjectSource@converter@util@protobuf@google Function : ReadVarint64@CodedInputStream@io@protobuf@google https://github.com/sagarpant1/protobuf/blob/6b1d0f11493ef2317ea74aa00804835a10ebaf19/src/google/protobuf/util/internal/protostream_objectsource.cc#L955 Issue in: buffer64

Code extract:

    }
    case google::protobuf::Field::TYPE_INT64: {
      uint64 buffer64;
      stream_->ReadVarint64(&buffer64); <------ HERE
      result = StrCat(bit_cast<int64>(buffer64));
      break;

How can I fix it? Fix provided in corresponding Pull Request.

Instance 28 File : src/google/protobuf/util/internal/protostream_objectsource.cc Enclosing Function : ReadFieldValueAsString@ProtoStreamObjectSource@converter@util@protobuf@google Function : ReadVarint32@CodedInputStream@io@protobuf@google https://github.com/sagarpant1/protobuf/blob/6b1d0f11493ef2317ea74aa00804835a10ebaf19/src/google/protobuf/util/internal/protostream_objectsource.cc#L961 Issue in: buffer32

Code extract:

    }
    case google::protobuf::Field::TYPE_UINT32: {
      uint32 buffer32;
      stream_->ReadVarint32(&buffer32); <------ HERE
      result = StrCat(bit_cast<uint32>(buffer32));
      break;

How can I fix it? Fix provided in corresponding Pull Request.

Instance 29 File : src/google/protobuf/util/internal/protostream_objectsource.cc Enclosing Function : ReadFieldValueAsString@ProtoStreamObjectSource@converter@util@protobuf@google Function : ReadVarint64@CodedInputStream@io@protobuf@google https://github.com/sagarpant1/protobuf/blob/6b1d0f11493ef2317ea74aa00804835a10ebaf19/src/google/protobuf/util/internal/protostream_objectsource.cc#L967 Issue in: buffer64

Code extract:

    }
    case google::protobuf::Field::TYPE_UINT64: {
      uint64 buffer64;
      stream_->ReadVarint64(&buffer64); <------ HERE
      result = StrCat(bit_cast<uint64>(buffer64));
      break;

How can I fix it? Fix provided in corresponding Pull Request.

Instance 30 File : src/google/protobuf/util/internal/protostream_objectsource.cc Enclosing Function : ReadFieldValueAsString@ProtoStreamObjectSource@converter@util@protobuf@google Function : ReadVarint32@CodedInputStream@io@protobuf@google https://github.com/sagarpant1/protobuf/blob/6b1d0f11493ef2317ea74aa00804835a10ebaf19/src/google/protobuf/util/internal/protostream_objectsource.cc#L973 Issue in: buffer32

Code extract:

    }
    case google::protobuf::Field::TYPE_SINT32: {
      uint32 buffer32;
      stream_->ReadVarint32(&buffer32); <------ HERE
      result = StrCat(WireFormatLite::ZigZagDecode32(buffer32));
      break;

How can I fix it? Fix provided in corresponding Pull Request.

Instance 31 File : src/google/protobuf/util/internal/protostream_objectsource.cc Enclosing Function : ReadFieldValueAsString@ProtoStreamObjectSource@converter@util@protobuf@google Function : ReadVarint64@CodedInputStream@io@protobuf@google https://github.com/sagarpant1/protobuf/blob/6b1d0f11493ef2317ea74aa00804835a10ebaf19/src/google/protobuf/util/internal/protostream_objectsource.cc#L979 Issue in: buffer64

Code extract:

    }
    case google::protobuf::Field::TYPE_SINT64: {
      uint64 buffer64;
      stream_->ReadVarint64(&buffer64); <------ HERE
      result = StrCat(WireFormatLite::ZigZagDecode64(buffer64));
      break;

How can I fix it? Fix provided in corresponding Pull Request.

Instance 32 File : src/google/protobuf/util/internal/protostream_objectsource.cc Enclosing Function : ReadFieldValueAsString@ProtoStreamObjectSource@converter@util@protobuf@google Function : ReadLittleEndian32@CodedInputStream@io@protobuf@google https://github.com/sagarpant1/protobuf/blob/6b1d0f11493ef2317ea74aa00804835a10ebaf19/src/google/protobuf/util/internal/protostream_objectsource.cc#L985 Issue in: buffer32

Code extract:

    }
    case google::protobuf::Field::TYPE_SFIXED32: {
      uint32 buffer32;
      stream_->ReadLittleEndian32(&buffer32); <------ HERE
      result = StrCat(bit_cast<int32>(buffer32));
      break;

How can I fix it? Fix provided in corresponding Pull Request.

Instance 33 File : src/google/protobuf/util/internal/protostream_objectsource.cc Enclosing Function : ReadFieldValueAsString@ProtoStreamObjectSource@converter@util@protobuf@google Function : ReadLittleEndian64@CodedInputStream@io@protobuf@google https://github.com/sagarpant1/protobuf/blob/6b1d0f11493ef2317ea74aa00804835a10ebaf19/src/google/protobuf/util/internal/protostream_objectsource.cc#L991 Issue in: buffer64

Code extract:

    }
    case google::protobuf::Field::TYPE_SFIXED64: {
      uint64 buffer64;
      stream_->ReadLittleEndian64(&buffer64); <------ HERE
      result = StrCat(bit_cast<int64>(buffer64));
      break;

How can I fix it? Fix provided in corresponding Pull Request.

Instance 34 File : src/google/protobuf/util/internal/protostream_objectsource.cc Enclosing Function : ReadFieldValueAsString@ProtoStreamObjectSource@converter@util@protobuf@google Function : ReadLittleEndian32@CodedInputStream@io@protobuf@google https://github.com/sagarpant1/protobuf/blob/6b1d0f11493ef2317ea74aa00804835a10ebaf19/src/google/protobuf/util/internal/protostream_objectsource.cc#L997 Issue in: buffer32

Code extract:

    }
    case google::protobuf::Field::TYPE_FIXED32: {
      uint32 buffer32;
      stream_->ReadLittleEndian32(&buffer32); <------ HERE
      result = StrCat(bit_cast<uint32>(buffer32));
      break;

How can I fix it? Fix provided in corresponding Pull Request.

Instance 35 File : src/google/protobuf/util/internal/protostream_objectsource.cc Enclosing Function : ReadFieldValueAsString@ProtoStreamObjectSource@converter@util@protobuf@google Function : ReadLittleEndian64@CodedInputStream@io@protobuf@google https://github.com/sagarpant1/protobuf/blob/6b1d0f11493ef2317ea74aa00804835a10ebaf19/src/google/protobuf/util/internal/protostream_objectsource.cc#L1003 Issue in: buffer64

Code extract:

    }
    case google::protobuf::Field::TYPE_FIXED64: {
      uint64 buffer64;
      stream_->ReadLittleEndian64(&buffer64); <------ HERE
      result = StrCat(bit_cast<uint64>(buffer64));
      break;

How can I fix it? Fix provided in corresponding Pull Request.

Instance 36 File : src/google/protobuf/util/internal/protostream_objectsource.cc Enclosing Function : ReadFieldValueAsString@ProtoStreamObjectSource@converter@util@protobuf@google Function : ReadLittleEndian32@CodedInputStream@io@protobuf@google https://github.com/sagarpant1/protobuf/blob/6b1d0f11493ef2317ea74aa00804835a10ebaf19/src/google/protobuf/util/internal/protostream_objectsource.cc#L1009 Issue in: buffer32

Code extract:

    }
    case google::protobuf::Field::TYPE_FLOAT: {
      uint32 buffer32;
      stream_->ReadLittleEndian32(&buffer32); <------ HERE
      result = SimpleFtoa(bit_cast<float>(buffer32));
      break;

How can I fix it? Fix provided in corresponding Pull Request.

Instance 37 File : src/google/protobuf/util/internal/protostream_objectsource.cc Enclosing Function : ReadFieldValueAsString@ProtoStreamObjectSource@converter@util@protobuf@google Function : ReadLittleEndian64@CodedInputStream@io@protobuf@google https://github.com/sagarpant1/protobuf/blob/6b1d0f11493ef2317ea74aa00804835a10ebaf19/src/google/protobuf/util/internal/protostream_objectsource.cc#L1015 Issue in: buffer64

Code extract:

    }
    case google::protobuf::Field::TYPE_DOUBLE: {
      uint64 buffer64;
      stream_->ReadLittleEndian64(&buffer64); <------ HERE
      result = SimpleDtoa(bit_cast<double>(buffer64));
      break;

How can I fix it? Fix provided in corresponding Pull Request.

Instance 38 File : src/google/protobuf/util/internal/protostream_objectsource.cc Enclosing Function : ReadFieldValueAsString@ProtoStreamObjectSource@converter@util@protobuf@google Function : ReadVarint32@CodedInputStream@io@protobuf@google https://github.com/sagarpant1/protobuf/blob/6b1d0f11493ef2317ea74aa00804835a10ebaf19/src/google/protobuf/util/internal/protostream_objectsource.cc#L1021 Issue in: buffer32

Code extract:

    }
    case google::protobuf::Field::TYPE_ENUM: {
      uint32 buffer32;
      stream_->ReadVarint32(&buffer32); <------ HERE
      // Get the nested enum type for this field.
      // TODO(skarvaje): Avoid string manipulation. Find ways to speed this

How can I fix it? Fix provided in corresponding Pull Request.

Instance 39 File : src/google/protobuf/util/internal/protostream_objectsource.cc Enclosing Function : ReadFieldValueAsString@ProtoStreamObjectSource@converter@util@protobuf@google Function : ReadVarint32@CodedInputStream@io@protobuf@google https://github.com/sagarpant1/protobuf/blob/6b1d0f11493ef2317ea74aa00804835a10ebaf19/src/google/protobuf/util/internal/protostream_objectsource.cc#L1039 Issue in: buffer32

Code extract:

    }
    case google::protobuf::Field::TYPE_STRING: {
      uint32 buffer32;
      stream_->ReadVarint32(&buffer32);  // string size. <------ HERE
      stream_->ReadString(&result, buffer32);
      break;

How can I fix it? Fix provided in corresponding Pull Request.

Instance 40 File : src/google/protobuf/util/internal/protostream_objectsource.cc Enclosing Function : ReadFieldValueAsString@ProtoStreamObjectSource@converter@util@protobuf@google Function : ReadVarint32@CodedInputStream@io@protobuf@google https://github.com/sagarpant1/protobuf/blob/6b1d0f11493ef2317ea74aa00804835a10ebaf19/src/google/protobuf/util/internal/protostream_objectsource.cc#L1045 Issue in: buffer32

Code extract:

    }
    case google::protobuf::Field::TYPE_BYTES: {
      uint32 buffer32;
      stream_->ReadVarint32(&buffer32);  // bytes size. <------ HERE
      stream_->ReadString(&result, buffer32);
      break;

How can I fix it? Fix provided in corresponding Pull Request.

sagarpant1 / protobuf

Potential issue in src/google/protobuf/util/internal/protostream_objectsource.cc: Unchecked return from initialization function #3

What is a Conditionally Uninitialized Variable? The return value of a function that is potentially used to initialize a local variable is not checked. Therefore, reading the local variable may result in undefined behavior.