OSGi Class Loader - Githubissues

sagarswathi / h2database

Automatically exported from code.google.com/p/h2database

0 stars 1 forks source link

OSGi Class Loader #467

Closed GoogleCodeExporter closed 8 years ago

GoogleCodeExporter commented 8 years ago

This patch add the ability to create reference to class on other ClassLoader 
(other OSGi bundles for ex.)
A unit test has been written for this ClassFactory. But not for OSGi has it 
requires a working OSGi context. But the test is done on h2spatial OSGi junit 
test.

ObjectDataType of MVStore use Utils.(de)serialize. May be there is a reason for 
this duplicate code, please check it.

When it will be merged, I will merge the master of h2spatial and add it on our 
continuous integration server jenkins.orbisgis.org

Thank you

Original issue reported on code.google.com by nico.de...@gmail.com on 23 May 2013 at 11:32

Attachments:

h2_final_patch.diff

GoogleCodeExporter commented 8 years ago

Hi,

Do you expect some other modifications, or there are issues on this patch ?

Thank you

Original comment by nico.de...@gmail.com on 29 May 2013 at 9:25

GoogleCodeExporter commented 8 years ago

The patch looks good, I will apply it and test it on my side before committing 
it.

> ObjectDataType of MVStore use Utils.(de)serialize. May be there is a reason 
for this duplicate code, please check it.

I don't want to blow up the MVStore jar file, that's why I will keep it 
duplicated.

Original comment by thomas.t...@gmail.com on 31 May 2013 at 2:12

Changed state: Accepted

GoogleCodeExporter commented 8 years ago

Original comment by thomas.t...@gmail.com on 31 May 2013 at 2:13

Changed state: Started

GoogleCodeExporter commented 8 years ago

> ObjectDataType of MVStore use Utils.(de)serialize

Your code should not rely on the serialization used by the ObjectDataType. If 
it does, then something is wrong: you would use the MVStore directly instead of 
using the MVTableEngine / ValueDataType (which uses Utils.(de)serialize).

Original comment by thomas.t...@gmail.com on 31 May 2013 at 2:19

GoogleCodeExporter commented 8 years ago

Hi, h2 spatial code works without this MVStore diff then you can ignore my diff 
about MVStore.

Original comment by nico.de...@gmail.com on 12 Jun 2013 at 9:26

GoogleCodeExporter commented 8 years ago

Have you an idea about when this patch will be added to h2 ? Thanks

Original comment by nico.de...@gmail.com on 12 Jun 2013 at 3:15

GoogleCodeExporter commented 8 years ago

I made a few formatting changes and have now committed the patch in 
https://code.google.com/p/h2database/source/detail?r=4985

If you want you can now verify it is fixed.

Original comment by thomas.t...@gmail.com on 28 Jul 2013 at 3:15

GoogleCodeExporter commented 8 years ago

Thank you, fixed

Original comment by nico.de...@gmail.com on 23 Aug 2013 at 1:11

GoogleCodeExporter commented 8 years ago

I found another way to extend h2 through OSGi by using Fragment Bundles. And my 
patch is not a good answer to OSGi issues as a DataBase could not be reopened 
if an OSGi bundle is not found with the same name/version.

I'm sorry but I advise to remove the modification on DbDriverActivator.java 
before someone use it.

http://code.google.com/p/h2database/source/diff?spec=svn5093&r=4985&format=side&
path=/trunk/h2/src/main/org/h2/util/DbDriverActivator.java

Original comment by nico.de...@gmail.com on 10 Sep 2013 at 7:28

GoogleCodeExporter commented 8 years ago

Should be fixed in the todays release (please verify)

Original comment by thomas.t...@gmail.com on 19 Oct 2013 at 8:34

Changed state: Fixed