search

sagdutt / Raze-LibGdx

0 stars 2 forks source link

Rename socket IO events for clarity #5

Open sagdutt opened 3 years ago

sagdutt commented 3 years ago

We should rename the following events in all of their occurences throughout the code since the names don't really correspond to their function.

PlayerMoved -> PlayerUpdated GetPlayers -> GetExistingPlayers

Changes are required in:

  1. https://github.com/sagdutt/Raze-LibGdx/blob/master/core/src/com/mygdx/game/event/events/PlayerMovedEvent.java
  2. https://github.com/sagdutt/Raze-LibGdx/blob/master/core/src/com/mygdx/game/event/events/GetPlayersEvent.java
  3. https://github.com/sagdutt/Raze-LibGdx/blob/master/core/src/com/mygdx/game/constant/SocketEventConstants.java#L15-L17
  4. https://github.com/sagdutt/Raze-LibGdx/blob/master/core/src/com/mygdx/game/screen/ArenaScreen.java#L182-L202
  5. https://github.com/sagdutt/Raze-LibGdx/blob/master/core/src/com/mygdx/game/client/SocketIOClient.java#L85-L134

Corresponding changes are also required in https://github.com/sagdutt/Raze-NodeServer/blob/master/index.js

syedmalimustafa commented 3 years ago

Can you assign this task to me?

sagdutt commented 3 years ago

Can you assign this task to me?

Sure