sagebind / isahc

The practical HTTP client that is fun to use.
https://docs.rs/isahc
MIT License
711 stars 62 forks source link

Remove parking lot dependency #415

Closed sagebind closed 2 years ago

sagebind commented 2 years ago

Remove need for upgradeable read-write lock from parking lot in PSL cache by refreshing the list asynchronously in a background thread. This doesn't make much performance difference unless we decide to swap the cache atomically, but allows us to remove a dependency only used in one small location.

codecov[bot] commented 2 years ago

Codecov Report

Base: 52.03% // Head: 52.38% // Increases project coverage by +0.34% :tada:

Coverage data is based on head (5e3d9d9) compared to base (07e3044). Patch coverage: 100.00% of modified lines in pull request are covered.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #415 +/- ## ========================================== + Coverage 52.03% 52.38% +0.34% ========================================== Files 52 52 Lines 5806 5815 +9 ========================================== + Hits 3021 3046 +25 + Misses 2785 2769 -16 ``` | [Impacted Files](https://codecov.io/gh/sagebind/isahc/pull/415?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Stephen+M.+Coakley) | Coverage Δ | | |---|---|---| | [src/cookies/psl/mod.rs](https://codecov.io/gh/sagebind/isahc/pull/415/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Stephen+M.+Coakley#diff-c3JjL2Nvb2tpZXMvcHNsL21vZC5ycw==) | `95.08% <100.00%> (+14.12%)` | :arrow_up: | | [src/lib.rs](https://codecov.io/gh/sagebind/isahc/pull/415/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Stephen+M.+Coakley#diff-c3JjL2xpYi5ycw==) | `16.90% <0.00%> (+0.14%)` | :arrow_up: | Help us with your feedback. Take ten seconds to tell us [how you rate us](https://about.codecov.io/nps?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Stephen+M.+Coakley). Have a feature suggestion? [Share it here.](https://app.codecov.io/gh/feedback/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Stephen+M.+Coakley)

:umbrella: View full report at Codecov.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.