sagebind / isahc

The practical HTTP client that is fun to use.
https://docs.rs/isahc
MIT License
705 stars 62 forks source link

Remove several features from futures-lite #417

Closed sagebind closed 1 year ago

sagebind commented 1 year ago

Disable default features in futures-lite which require several dependencies that are actually unnecessary for the very few things we use from it. Re-implement these few features instead.

codecov[bot] commented 1 year ago

Codecov Report

Base: 52.48% // Head: 52.70% // Increases project coverage by +0.21% :tada:

Coverage data is based on head (67856d4) compared to base (a7c7835). Patch coverage: 78.66% of modified lines in pull request are covered.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #417 +/- ## ========================================== + Coverage 52.48% 52.70% +0.21% ========================================== Files 53 56 +3 Lines 5794 5846 +52 ========================================== + Hits 3041 3081 +40 - Misses 2753 2765 +12 ``` | [Impacted Files](https://codecov.io/gh/sagebind/isahc/pull/417?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Stephen+M.+Coakley) | Coverage Δ | | |---|---|---| | [src/handler.rs](https://codecov.io/gh/sagebind/isahc/pull/417/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Stephen+M.+Coakley#diff-c3JjL2hhbmRsZXIucnM=) | `80.82% <ø> (ø)` | | | [src/lib.rs](https://codecov.io/gh/sagebind/isahc/pull/417/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Stephen+M.+Coakley#diff-c3JjL2xpYi5ycw==) | `17.32% <ø> (+0.55%)` | :arrow_up: | | [src/text.rs](https://codecov.io/gh/sagebind/isahc/pull/417/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Stephen+M.+Coakley#diff-c3JjL3RleHQucnM=) | `81.39% <0.00%> (ø)` | | | [tests/request\_body.rs](https://codecov.io/gh/sagebind/isahc/pull/417/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Stephen+M.+Coakley#diff-dGVzdHMvcmVxdWVzdF9ib2R5LnJz) | `100.00% <ø> (ø)` | | | [src/util/io.rs](https://codecov.io/gh/sagebind/isahc/pull/417/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Stephen+M.+Coakley#diff-c3JjL3V0aWwvaW8ucnM=) | `68.75% <68.75%> (ø)` | | | [src/util/mod.rs](https://codecov.io/gh/sagebind/isahc/pull/417/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Stephen+M.+Coakley#diff-c3JjL3V0aWwvbW9kLnJz) | `17.64% <75.00%> (ø)` | | | [src/util/future.rs](https://codecov.io/gh/sagebind/isahc/pull/417/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Stephen+M.+Coakley#diff-c3JjL3V0aWwvZnV0dXJlLnJz) | `80.00% <80.00%> (ø)` | | | [src/agent/mod.rs](https://codecov.io/gh/sagebind/isahc/pull/417/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Stephen+M.+Coakley#diff-c3JjL2FnZW50L21vZC5ycw==) | `77.77% <100.00%> (ø)` | | | [src/body/mod.rs](https://codecov.io/gh/sagebind/isahc/pull/417/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Stephen+M.+Coakley#diff-c3JjL2JvZHkvbW9kLnJz) | `83.78% <100.00%> (+0.29%)` | :arrow_up: | | [src/body/sync.rs](https://codecov.io/gh/sagebind/isahc/pull/417/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Stephen+M.+Coakley#diff-c3JjL2JvZHkvc3luYy5ycw==) | `81.37% <100.00%> (ø)` | | | ... and [7 more](https://codecov.io/gh/sagebind/isahc/pull/417/diff?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Stephen+M.+Coakley) | | Help us with your feedback. Take ten seconds to tell us [how you rate us](https://about.codecov.io/nps?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Stephen+M.+Coakley). Have a feature suggestion? [Share it here.](https://app.codecov.io/gh/feedback/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Stephen+M.+Coakley)

:umbrella: View full report at Codecov.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.