codecov[bot]
commented
2 years ago Codecov Report
Base: 52.47% // Head: 52.48% // Increases project coverage by +0.00% :tada:
Coverage data is based on head (
a2833c1) compared to base (6917903). Patch coverage: 89.58% of modified lines in pull request are covered.
Additional details and impacted files
```diff @@ Coverage Diff @@ ## master #418 +/- ## ======================================= Coverage 52.47% 52.48% ======================================= Files 53 53 Lines 5795 5794 -1 ======================================= Hits 3041 3041 + Misses 2754 2753 -1 ``` | [Impacted Files](https://codecov.io/gh/sagebind/isahc/pull/418?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Stephen+M.+Coakley) | Coverage Δ | | |---|---|---| | [src/cookies/psl/mod.rs](https://codecov.io/gh/sagebind/isahc/pull/418/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Stephen+M.+Coakley#diff-c3JjL2Nvb2tpZXMvcHNsL21vZC5ycw==) | `92.06% <89.58%> (-3.02%)` | :arrow_down: | | [src/macros.rs](https://codecov.io/gh/sagebind/isahc/pull/418/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Stephen+M.+Coakley#diff-c3JjL21hY3Jvcy5ycw==) | `6.37% <0.00%> (-0.21%)` | :arrow_down: | | [src/lib.rs](https://codecov.io/gh/sagebind/isahc/pull/418/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Stephen+M.+Coakley#diff-c3JjL2xpYi5ycw==) | `16.76% <0.00%> (+0.08%)` | :arrow_up: | Help us with your feedback. Take ten seconds to tell us [how you rate us](https://about.codecov.io/nps?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Stephen+M.+Coakley). Have a feature suggestion? [Share it here.](https://app.codecov.io/gh/feedback/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Stephen+M.+Coakley):umbrella: View full report at Codecov.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.
Make PSL system less reliant on statics and easier to reliably test. In the future we might do more internal refactoring to make the PSL cache tied to individual clients, but I'm saving that for later.