search

sagemath / cypari2

Python interface to the number theory library PARI/GP. Source repository for https://pypi.org/project/cypari2/
https://cypari2.readthedocs.io/en/latest/
GNU General Public License v2.0
30 stars 28 forks source link

.github/workflows/main.yml: Add portability/integration testing with Sage #140

Closed mkoeppe closed 12 months ago

mkoeppe commented 1 year ago

We use the reusable workflows from Sage to test portability and integration with Sage.

mkoeppe commented 1 year ago

rebased

dimpase commented 1 year ago

I guess this has to wait until Sage's CI is in order.

mkoeppe commented 1 year ago

@videlec @dimpase Ready for merging.

dimpase commented 1 year ago

Don't we want docs/Makefile and docs/source/ in MANIFEST.in ?

mkoeppe commented 1 year ago

Let's keep this PR focused on what is in its title please.

dimpase commented 1 year ago

I am asking a legitimate question - you added a Makefile to Manifest, I wonder whether there are more Makefiles etc that should be added.

mkoeppe commented 12 months ago

I am asking a legitimate question - you added a Makefile to Manifest, I wonder whether there are more Makefiles etc that should be added.

In this PR, no, because Sage does not do anything with cypari2 documentation.

Otherwise, also no, because when you install using pip from an sdist, the documentation is not to be built. This is something that developers would do directly in a git tree.

dimpase commented 12 months ago

OK, fine