sagemath / cysignals

cysignals: interrupt and signal handling for Cython. Source repository for https://pypi.org/project/cysignals/
GNU Lesser General Public License v3.0
44 stars 23 forks source link

Fix macro definition of #128 #135

Closed kliem closed 3 years ago

kliem commented 3 years ago

The macro definition of #128 are not correct.

One needs to be aware of the fact that the macros are either 1 or undefined. Currently, #if CYSIGNALS_CXX_ATOMIC will evaluate to true with -fopenmp even if not available.

Also #undef ... is overloaded. In src/cysignals/cysignals_config.h.in it means according to AC_DEFINE: Use the configured value, if available. This is very much different from what #undef ... usually means.

kliem commented 3 years ago

Tracked by #134