sagemath / cysignals

cysignals: interrupt and signal handling for Cython. Source repository for https://pypi.org/project/cysignals/
GNU Lesser General Public License v3.0
43 stars 23 forks source link

Automatically confirm any prompts from conda install #137

Closed embray closed 3 years ago

embray commented 3 years ago

This should fix failing builds like https://travis-ci.com/github/sagemath/cysignals/jobs/489407955

embray commented 3 years ago

This seems to be better now, but there is still a problem with the Python 3.4 builds, in that conda installs Cython 0.27, but cysignals has its Cython dependency set to 0.28, so even with pip install --no-deps it still builds a newer Cython to satisfy setup_requires, making the builds take extra long. I wonder if it would be OK to downgrade to Cython 0.27 at a minimum.

embray commented 3 years ago

In fact the Cython>=0.28 dependency is required for the build to work, and would be a pain to undo just for supporting Python 3.4.

Cython 0.28 (and 0.29) does have wheels for Python 3.4, so maybe I can just have it install those. I don't know why pip is opting instead to install an alpha version from source.

embray commented 3 years ago

Using pip to upgrade to Cython 0.29 worked on Linux, but not on MacOS. Apparently this is a bug that did exist at one time but is fixed in newer pip versions: https://github.com/pypa/pip/issues/3801