search

sagemath / cysignals

cysignals: interrupt and signal handling for Cython. Source repository for https://pypi.org/project/cysignals/
GNU Lesser General Public License v3.0
44 stars 23 forks source link

Drop Python 2 support; bump minimum Python version to 3.6 #142

Closed embray closed 3 years ago

embray commented 3 years ago

There are really very few Python 2-isms in the main cysignals code. Mostly just some future imports and one or two other bits.

Almost to the point where it's not worth dropping completely; nevertheless better not to encourage Python 2 use. The main point of this is also to drop support from the CI.

For now I kept language_level=2 for the Cython modules, but we could probably change it to 3 as well. There are very few places in cysignals where this matters much.

Finally, added a few f-strings in the pure Python code where appropriate, now that it's possible.

embray commented 3 years ago

The one travis failure looks like a fluke, but Travis is so broken these days, trying to restart a job fails every time I try.

Since the build for the PR is exactly the same thing, and it passed, that's good enough for me.