search

sagemath / cysignals

cysignals: interrupt and signal handling for Cython. Source repository for https://pypi.org/project/cysignals/
GNU Lesser General Public License v3.0
43 stars 23 forks source link

Create wheels.yml #158

Closed dimpase closed 2 years ago

dimpase commented 2 years ago

Using the template from https://github.com/pypa/cibuildwheel - just dropping Windows. It works, although wheels might need testing. See artefacts on https://github.com/dimpase/cysignals/actions/runs/1525774573 (is an archive of built wheels)

dimpase commented 2 years ago

this will close #153.

dimpase commented 2 years ago

Any reason to not directly push it to pypi as described here https://cibuildwheel.readthedocs.io/en/stable/deliver-to-pypi/?

I didn't know about GitHub repo's secrets until I read the above - I saw somewhere an example with PyPI token in the open (ok for a self-hosted runner...), and didn't think of it as a good idea.

Anyhow, the next step would be testing the wheels -- cibuildwheel has facilities for it, using pytest, I think, but I don't even know of a good test for cysignals - besides installing the wheel and checking it imports.

Only after this would could think of an automatic upload to PyPI - we don't want to spam it with broken wheels.