search

sagemath / cysignals

cysignals: interrupt and signal handling for Cython
GNU Lesser General Public License v3.0
44 stars 23 forks source link

Add general signal hook but keep pari #181

Closed mkoeppe closed 10 months ago

mkoeppe commented 10 months ago

Introduces a general hook as proposed in the discussion of https://github.com/sagemath/cypari2/pull/109.

Split out from #166. @kliem @videlec

mkoeppe commented 10 months ago

@malb @dimpase Let's merge this please

mkoeppe commented 10 months ago

Yes, this has already been tested, and the corresponding PR https://github.com/sagemath/cypari2/pull/117 was already merged (.... by you, @dimpase) into cypari2, until someone decided to back it out again without discussion. https://github.com/sagemath/cypari2/pull/130 has the change on the cypari2 side of things again.

Here I am using an approach that needs less coordination. Keeping the cypari2-specific code (so that current cypari2 works) and adding a general hook (so that future cypari2 with https://github.com/sagemath/cypari2/pull/130 can work).