search

sagemath / cysignals

cysignals: interrupt and signal handling for Cython
GNU Lesser General Public License v3.0
44 stars 23 forks source link

README.rst, VERSION: Update to 1.11.3 #186

Closed mkoeppe closed 9 months ago

mkoeppe commented 9 months ago

After merging this PR, a release can be tagged. @dimpase @malb

dimpase commented 9 months ago

one problem to fix for the release is to make docs build properly.

dimpase commented 9 months ago

can we apply #187 first?

dimpase commented 9 months ago

Do you know how to make releases here?

mkoeppe commented 9 months ago

Just create a release tag. If all works well, it will push sdist and wheels to PyPI. (It should have the necessary credentials from the sagemath org...)

dimpase commented 9 months ago

there was already the source release on PyPI, not sure why :-)

dimpase commented 9 months ago

Should I open a PR to bump cysignals in Sage?

mkoeppe commented 9 months ago

there was already the source release on PyPI, not sure why :-)

That part of the workflow ran already when you merged the PR into main. https://github.com/sagemath/cysignals/actions/runs/6409434519/job/17400602464

This shouldn't really happen, it's supposed to happen only when a tag is placed. I'll fix this.

The wheels have also been built correctly already in https://github.com/sagemath/cysignals/actions/runs/6409587384, but something went wrong in the upload step. I'll upload the wheels manually for this time and will sent a PR to fix the problem in the workflow.

The workflow changes are done in #188, please merge

mkoeppe commented 9 months ago

Should I open a PR to bump cysignals in Sage?

Yes please!

dimpase commented 9 months ago

https://github.com/sagemath/sage/pull/36402