search

sagemath / publications

Source for https://www.sagemath.org/library-publications.html; submit Issues/PRs here to add/update citations of documents citing Sage
25 stars 31 forks source link

added 8 paper by Cremona et al #129

Closed JohnCremona closed 2 years ago

JohnCremona commented 2 years ago

I added 8 papers to bibliography-sage.bib, taking the Bibtex entries from Google Scholar but changing the tags to something more sensible. I did a bit of massaging to get "make" to not object to my additions (though why I had to change "year" to "date" and "journal" to "journaltitle" is a mystery to me. But make still chokes on at least one entry there not mine (Garfinkel-Bennoun-Deeds-VanValkenburgh2022) for the same reason (it has journal but not journaltitle),

haraldschilly commented 2 years ago

The problem is e6cdeb2f1729cf9ac6deb61b6ef473867e90371f and 356ef19157e964b25df9694c527aa8912d700dc6 by @dimpase … directly pushed to master without going through a PR review or testing. I've merged your PR and I'll fix these issues now. Thank you for adding this and well, sorry for the confusion.

dimpase commented 2 years ago

oops, sorry. I haven't understood how fragile this use of bibtex is.

haraldschilly commented 2 years ago

no problem … I guess this parser lib is following some old standards, I don't know.

dimpase commented 2 years ago

Are you using an old pybtex? The current version is 0.24.0

dimpase commented 2 years ago

it claims to be fully compatible with bibtex.

dimpase commented 2 years ago

hmm, no. It's a problem in the vintage pubparse.py...

haraldschilly commented 2 years ago

Well, maybe, I had 0.22.2, now updated. In any case, I was curious. There is a biblatex.pdf (not bibtex!) and it seems to only have a journaltitle. I'm guessing all sane tools just automatically convert.

Screenshot from 2022-02-24 19-56-11

dimpase commented 2 years ago

It's a bug in pubparse.py:

aj = article.get("journal", article['journaltitle'])

breaks, because Python has eager parsing of arguments, and so absense of 'journaltitle' leads to a key error straight away.

dimpase commented 2 years ago

Ditto in

ay = article.get("year", article['date'])
dimpase commented 2 years ago

OK, I'll fix these.

JohnCremona commented 2 years ago

Thanks @haraldschilly and @dimpase for your work on this

dimpase commented 2 years ago

John, perhaps you can review my fixes for journal stuff at #131 ?

JohnCremona commented 2 years ago

John, perhaps you can review my fixes for journal stuff at #131 ?

OK, I am looking at it now. -- correction, I see that @haraldschilly got there first. Thanks

dimpase commented 2 years ago

It's already merged by Harald :-) It should now be easier to add bibtex entries, no more requirement of journaltitle etc ..

JohnCremona commented 2 years ago

Looking at https://www.sagemath.org/library-publications.html item 395 has a problem caused by having \mathbb{Q} in the title.

haraldschilly commented 2 years ago

Looking at https://www.sagemath.org/library-publications.html item 395 has a problem caused by having \mathbb{Q} in the title.

sounds like https://github.com/sagemath/publications/issues/41, I'll make a note