sagemath / publications

Source for https://www.sagemath.org/library-publications.html; submit Issues/PRs here to add/update citations of documents citing Sage
25 stars 31 forks source link

Add more papers and correct some errors #134

Closed enriqueartal closed 2 years ago

enriqueartal commented 2 years ago

Added some papers and corrected some mistakes detected in the web page. Please, undo if it causes problems

haraldschilly commented 2 years ago

ok, I merged this, but there are still issues. Could you just go ahead and wrap those formulas in {$...$} brackets, which means "keep this as it is"? That should fix the problems.

enriqueartal commented 2 years ago

Anyway, sorry for the noise. Is it possible to test locally?

haraldschilly commented 2 years ago

Anyway, sorry for the noise. Is it possible to test locally?

you would have to checkout the website (this here is a submodule) → https://github.com/sagemath/website#getting-started

there are a few dependencies, nothing serious. then run make and open www/library-publications.html in your browser. make calls the publications submodule's make automatically.

If something is off, the most minimalistic way is to run make in the publications subdir first (make -C publications from the parent) and then python3 render.py

haraldschilly commented 2 years ago

I'll go through this and try to fix it.

haraldschilly commented 2 years ago

ok, I think I made some progress. I don't know why, but the parser was swallowing curly brackets. In 83d3f8fa93880a66ced3845e4847538bb370927f I changed that behavior and also went through and fixed some formulas. Also, all those cases where the font changes, need to be done in a bracket, e.g. {\mathfrak sf} and so on. In any case, here are examples, which look good to me now. There are probably a couple of other formulas that could be improved as well.

Screenshot from 2022-02-26 16-16-46 Screenshot from 2022-02-26 16-06-17 Screenshot from 2022-02-26 16-05-49 Screenshot from 2022-02-26 16-04-01