sagemath / sage-binder-env

A Binder repo for SageMath computing environment
GNU General Public License v3.0
27 stars 29 forks source link

Testing create-wsl-image.yml #20

Open soehms opened 2 hours ago

soehms commented 2 hours ago

This issue continues the discussion started in a sage-devel thread on Using Sage on Windows regarding the approach suggested by @tobiasdiez using a custom WSL distribution. An according implementation of this can be found here in .github/workflows/create-wsl-image.yml. Tests of it are documented in this issue.

soehms commented 2 hours ago

Testreport on commit https://github.com/sagemath/sage-binder-env/commit/7d49318fb7f35453d3b3b4596500e3c3e23f6ae2.

The test was on a VM running Windows 10 Home.

Again I was unable to paste the script into the Powershell terminal. This point worked better in my previous test last Saturday. But maybe this is a problem caused by the virtual machine. When this happens, the paste process is very slow, it seems to go line by line and at the end the code appears in reverse order in the terminal (see attached file paste.log).

So I saved the code from the editor under a different name sagemath-10.4-wsl-installer-test.ps1 and ran that instead. Now the installation of WSL was done. The tar-file was downloaded before rebooting the system. The output can be found in install_7d49318.log.

After rebooting the VM, I ran sagemath-10.4-wsl-installer-test.ps1 again. This gave me working Sage icons (see install_7d49318_part2.log).

Before installation, the VM had 19.4 GB of used disk space, after installation it took up about 35 GB. I think there should be potential to reduce that. In your post on sage-devel (in the Using Sage on Windows thread), you said:

My installer installs a minimized Sage (no build facility, no optional package, no local docs), basically the same sage that you get from the sage-binder-env (https://github.com/sagemath/sage-binder-env).

I guess you mean ghcr.io/sagemath/sage-binder-env:10.4? This is more than 3/5 larger than the according image on Docker Hub:

sebastian@SebaThinkPad:~$ docker images
REPOSITORY                         TAG          IMAGE ID       CREATED         SIZE
ghcr.io/sagemath/sage-binder-env   10.4         548c4e2559de   21 hours ago    8.37GB
sagemath/sagemath                  10.5.beta6   c952169891ff   2 weeks ago     5.14GB
sagemath/sagemath                  10.4         8d657a42f33a   3 months ago    5.21GB
computop/sage                      10.0         ae32949dc28d   16 months ago   9.39GB

Another suggestions: I think it would be worth considering user messages that make it clear that a reboot is required and the script needs to be called again afterwards. I did something similar regarding the installation of Docker Desktop (see section 2.1 of the documentation).