sagemath / sage-patchbot

Sage Patchbot
https://www.sagemath.org
Other
8 stars 17 forks source link

Get rid of "trusted authors" feature #121

Closed loefflerd closed 6 years ago

loefflerd commented 6 years ago

The trusted authors check is presumably intended as a security feature; but, as discussed on sage-devel at (https://groups.google.com/forum/#!topic/sage-devel/rSaesTu4MCE), it provides no actual security, because anyone with a trac account can set ticket "Author" fields to whatever they like. It also has the pernicious effect of making it harder for new Sage contributors to get their code positively reviewed. So I propose that this feature be removed, or at least disabled by default.