search

sagemath / sage-patchbot

Sage Patchbot
https://www.sagemath.org
Other
8 stars 17 forks source link

remove trusted users #122

Closed videlec closed 6 years ago

videlec commented 6 years ago

We do remove the concept of "trusted users" from client and server (fixes #121)

fchapoton commented 6 years ago

I disagree, but will not oppose.

embray commented 6 years ago

I'm +1 on this but it might have been nice to have some announcement that this was changed (since it required an update to the patchbot client--otherwise it dies trying to find the trusted authors list now).

videlec commented 6 years ago

How would you announce it? We can have an empty list of trusted users on the server that would also prevent the patchbot from doing anything. But I don't see the difference. Of course, something needs to be done on the wiki https://wiki.sagemath.org/buildbot before the release.

embray commented 6 years ago

@videlec I just meant a note, sage, on sage-devel that patchbot clients would need to be upgraded. Because now when they try to contact the server for the trusted authors list it sits there for a while getting 404s and then gives up, and then no tests work.

That's fine--I'm just saying that if a change to the server can't be made in a way that's backwards-compatible for old clients then this should be pointed out rather than patchbots starting to break unexpectedly.

fchapoton commented 6 years ago

my fault. I should not have upgraded the server without saying it loud on sage-devel. Now we need to make a patchbot "release" 2.7.1 and ask all clients to update.

fchapoton commented 6 years ago

or re-introduce the code on the server side, that was deleted with no reason..