pyflakes plugin doesn't understand lazy_import

sagemath / sage-patchbot

Sage Patchbot

https://www.sagemath.org

Other

8 stars 17 forks source link

pyflakes plugin doesn't understand lazy_import #128

Open loefflerd opened 6 years ago

loefflerd commented 6 years ago

See e.g. https://patchbot.sagemath.org/log/17093/debian/stretch/sid/x86_64/4.4.0-45-generic/fermat/2018-05-20%2019:45:08?plugin=pyflakes. Here the pyflakes plugin is complaining about "undefined name SL2Z" in modular/arithgroup/arithgroup_generic.py.

fchapoton commented 6 years ago

Well, just live with it. The patchbot is not smart. Once again, it is there to help find issues. It is in no way required that it becomes green before positive review.

loefflerd commented 6 years ago

Up to you. It's no problem to work around it, of course. I just thought you might not be aware of this behaviour, since the pyflakes plugin only analyses files modified in the ticket under test, and lazy_import isn't all that widely used.