search

sagemath / sage-patchbot

Sage Patchbot
https://www.sagemath.org
Other
8 stars 17 forks source link

AttributeError: 'NoneType' object has no attribute 'endswith' #132

Closed videlec closed 6 years ago

videlec commented 6 years ago

After testing ticket 0 the patchbot quasar stops suddenly with

Traceback (most recent call last):
  File "/usr/lib/python3.5/runpy.py", line 184, in _run_module_as_main
    "__main__", mod_spec)
  File "/usr/lib/python3.5/runpy.py", line 85, in _run_code
    exec(code, run_globals)
  File "/usr/labri/vdelecro/.local/lib/python3.5/site-packages/sage_patchbot/patchbot.py", line 1627, in <module>
    main(args)
  File "/usr/labri/vdelecro/.local/lib/python3.5/site-packages/sage_patchbot/patchbot.py", line 1586, in main
    res = patchbot.test_a_ticket(0)
  File "/usr/labri/vdelecro/.local/lib/python3.5/site-packages/sage_patchbot/patchbot.py", line 1256, in test_a_ticket
    if maybe_temp_root.endswith(temp_build_suffix + str(ticket['id'])):
AttributeError: 'NoneType' object has no attribute 'endswith'

As can be seen from the traceback the computer runs Python 3.5.

videlec commented 6 years ago

@embray It seems to be related to commits around temporary directories like 2b49c27. Do you know what should be done?

embray commented 6 years ago

I see, thanks for the report. I think I see what the problem is.

embray commented 6 years ago

@videlec can you test the latest version from b1e98e5 and see if that fixes it for you? If so I'll make a new release with the fix.

embray commented 6 years ago

Hold on, the fix itself has a typo...

embray commented 6 years ago

Try @ 481fc3e

videlec commented 6 years ago

Thanks for taking care of it. quasar is now running with sage-patchbot at 481fc3e

embray commented 6 years ago

Great, thanks for checking. I'll make a new release with this fix then.

embray commented 6 years ago

Release v2.8.1