search

sagemath / sage-patchbot

Sage Patchbot
https://www.sagemath.org
Other
8 stars 17 forks source link

Fixed finding lazy imports when the import has kwargs. #139

Closed MarkCBell closed 5 years ago

MarkCBell commented 5 years ago

Patchbots analysing sage patch 28234 have repeatedly crashed while running with the pyflakes plugin. This was caused by one of the changed files (src/sage/categories/pushout.py) using a lazy_import('sage.categories.rings', 'Rings', at_startup=True).

While the old version of the code for finding lazy imports previously removed terms that involved the deprecation= keyword argument, they did not handle the at_startup=True option. This updates the code to ignore all keyword terms. This means that the code does not crash.

fchapoton commented 5 years ago

Great ! Thanks a lot for having taken some of your time to improve the patchbot.