search

sagemath / sage-patchbot

Sage Patchbot
https://www.sagemath.org
Other
8 stars 17 forks source link

Update pyflakes and pycodestyle #143

Open tobiasdiez opened 4 years ago

tobiasdiez commented 4 years ago

pyflakes and pycodestyle have problems with the typing syntax that was added in https://trac.sagemath.org/ticket/29775, see https://patchbot.sagemath.org/ticket/29775/ for the output. It appears that these issues are fixed in the most recent versions of these tools (e.g. ​https://github.com/PyCQA/pyflakes/issues/247 and ​https://github.com/vim-syntastic/syntastic/issues/1667). Could they please be updated to the latest version

Moreover, one common problems seems to be that these tools need to be installed under python 3, since otherwise they check the files using python 2 syntax (e.g. ​https://github.com/vim-syntastic/syntastic/issues/1667#issuecomment-172538109).

fchapoton commented 4 years ago

The patchbot clients are supposed to run under python3. The pyflakes version is the one installed by the patchbot owner.

tobiasdiez commented 4 years ago

Ok, thanks. So who is the "patchbot owner" for the sage build, and how do I see which version of pyflakes is used?

fchapoton commented 4 years ago

To see the patchbot owner, click on the "log" and search for owner. In the next-to-last report for 29775, this is Clemens Heuberger.

There is currently no way to see which pyflakes version is used by a patchbot client.

Do you know if the fixes required are already in a released version of pyflakes and pycodestyle ?