search

sagemath / sage-patchbot

Sage Patchbot
https://www.sagemath.org
Other
8 stars 17 forks source link

Run patchbot on all tickets, including those with package changes #148

Open mkoeppe opened 2 years ago

mkoeppe commented 2 years ago

Skipping tickets that involve package changes is an outdated, unnecessary restriction. Just use configure --enable-download-from-upstream-url.

From https://groups.google.com/g/sage-devel/c/Qjhl1XHMll8/m/-uynTvkfBQAJ

fchapoton commented 2 years ago

This behaviour is here in patchbot.py :

                is_spkg = branch_updates_some_package() or ticket['spkgs']
                if is_spkg:
                    # ------------- treatment of spkgs -------------
                    state = 'spkg'
                    print("Ticket updates some package, hence not tested.")
                    self.to_skip[ticket['id']] = time.time() + 240 * 60 * 60

                if not is_spkg:

One can easily desactivate this check. Somebody needs to run a modified patchbot on a package-upgrade ticket to check that it works.

fchapoton commented 2 years ago

ok, now testing on #33160

fchapoton commented 2 years ago

failed on https://trac.sagemath.org/ticket/33160

testing now on https://trac.sagemath.org/ticket/33194