sagemath / sage-patchbot

Sage Patchbot
https://www.sagemath.org
Other
8 stars 17 forks source link

unhandled exception when testing unsafe tickets #38

Open rwst opened 10 years ago

rwst commented 10 years ago

After starting python patchbot.py with an unsafe ticket, this:

  File "/tmp/tmpmgC4H7-sage-git-temp-15178/src/bin/sage-runtests", line 48, in <module>
    os.path.join(os.environ["DOT_SAGE"], "valgrind"))
  File "/tmp/tmpmgC4H7-sage-git-temp-15178/local/lib/python/UserDict.py", line 23, in __getitem__
    raise KeyError(key)
KeyError: 'DOT_SAGE'
Traceback (most recent call last):
  File "local/bin/patchbot/patchbot.py", line 556, in test_a_ticket
  File "/home/ralf/git/sage-patchbot/src/util.py", line 107, in do_or_die
    raise exn_class, "%s %s" % (res, cmd)
Exception: 256 $SAGE_ROOT/sage -tp 3 --all --long

Obviously the logic setting DOT_SAGE in sage is not duplicated in patchbot, and patchbot should use as pristine DOT_SAGE, probably in /tmp.